Open Bug 1673588 Opened 1 year ago Updated 9 months ago

Change urlbar results so opening in a tab will open them in background, leaving the panel open

Categories

(Firefox :: Address Bar, enhancement, P2)

Desktop
All
enhancement
Points:
3

Tracking

()

ASSIGNED
Tracking Status
firefox82 --- affected
firefox83 --- affected
firefox84 --- affected

People

(Reporter: cbaica, Assigned: tawn)

References

Details

(Keywords: papercut)

Attachments

(1 file)

Suggested severity

  • S3

Affected versions

  • Fx83.0b4
  • Fx84.0a1

Affected platforms

  • win 10 x64
  • ubuntu 18.04

Steps to reproduce

  1. Launch Firefox.
  2. Write something in the address bar.
  3. From the drop down list middle click a result.
  4. From the drop down list middle click a one-off engine.

Expected result

  • Behavior for the middle click should be similar:
  1. a new-tab is opened in the background, drop-down still displayed.
  2. a new-tab is opened in the background, drop-down still displayed.

Actual result
3. a new-tab is opened with the search result and focused on.
4. a new-tab is opened in the background. search is performed with the clicked engine.

Regression range

  • Not a recent regression. Will come back with a regression range ASAP.

Additional notes

  • It would make sense to have a uniform behavior in the drop-down. As a user would want to open multiple tabs with different search engines in the background, the same case could be made for opening multiple suggestions.

This was discussed today at the UX meeting, it was decided we'd like to follow the behavior of other browsers here, where results opened in tabs will open in a background tab and the urlbar panel stays open. Shift allows to invert the behavior so that we open in a foreground tab and close the panel.
It should be implemented behind a feature pref, because it's a behavioral change and we want to ensure we have a way back in case of issues.

Summary: There is an inconsistency between middle clicking a search suggestion and a one-off engine → Change urlbar results so opening in a tab will open them in background, leaving the panel open
Severity: normal → S4
Type: defect → enhancement
Priority: -- → P2

some discussion and possible issues in bug 1364415

See Also: → 1364415
Keywords: papercut
Duplicate of this bug: 1436755
Duplicate of this bug: 1437348
Duplicate of this bug: 1498972
Duplicate of this bug: 1556326
Points: --- → 3

I took a stab at this. Sometimes keeping a menu/panel open can trigger inconspicuous buggy side-effects, but so far I haven't noticed any. Feedback? (Unlike moz-review, I didn't see any way to set reviewer after submitting. Must it now be in in commit message?)

Flags: needinfo?(mak)

I'm sorry, I have a long queue of reviews, I'll come to this but it may take some time.

I left some feedback on the patch, feel free to just set reviewer. You can edit the changeset directly in Phabricator to add a reviewer after submitting.
I think overall you touched the right code points, but it needs a bit more work to be top notch.

Flags: needinfo?(mak)
Assignee: nobody → stayopenmenu
Status: NEW → ASSIGNED
Attachment #9196726 - Attachment description: Bug 1673588 - Open in background and keep panel open when opening in tabs. → commit Bug 1673588 - Respect browser.tabs.loadInBackground and keep panel open when opening in tabs in background.
Attachment #9196726 - Attachment description: commit Bug 1673588 - Respect browser.tabs.loadInBackground and keep panel open when opening in tabs in background. → Bug 1673588 - Respect browser.tabs.loadInBackground and keep panel open when opening in tabs in background.

Addressed Marco's feedback, found/fixed bug in original patch & tweaked tests (including enabling detection for that bug).
Have not done Try run yet.

Just wanted to say that I'm eager to see this fix implemented before next ESR (v.91).

You need to log in before you can comment on or make changes to this bug.