1673634 - Custom margins don't account for page orientation

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Mark Striemer [:mstriemer]]

The custom margins picker always compares against the paperHeight for marginTop and marginBottom, and pageWidth for marginLeft and marginRight.

This comparison is only correct for portrait orientation, however. When the page is in landscape mode the marginTop and marginBottom would now be affecting the pageWidth.

STR

1. Set orientation to portrait, paper size to letter
2. Set margin top and bottom to 5"
3. Change orientation to landscape

Expected results: Maybe the margins rotate? Chrome/Edge resets custom to default on orientation change.
Actual results: The top+bottom margin is now greater than the rotated page height, the page is blank

Comment 1

[Emma Malysz]

Attachment: Bug 1673634: custom margins must factor in page orientation when calculating maximum values

When the orientation changes, we must recalculate the maximum height and width.
For portrait orientation, marginTop and marginBottom should be compared to the
paper width, and for landscape orientation, they should be compared to the paper
height (vice versa for marginLeft and marginRight).

If the custom margin values are valid after an orientation switch, they will
persist. If they are no longer valid, they will be reset to the default values,
and the margin dropdown will still have custom selected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1817390a4cbf
custom margins must factor in page orientation when calculating maximum values r=mstriemer

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1817390a4cbf

Comment 4

[Anca Soncutean, Desktop QA]

Reproduced with Fx 84.0a1(2020-10-27).
Verified fixed with Fx 85.0a1(2020-11-24) and Fx 84.0b4 on Windows 10, Ubuntu 18.04 and macOS 10.15.