1673733 - WNPanel devtools "Open What's New Panel" and "Render Selected Messages" buttons aren't working

Status: RESOLVED DUPLICATE of bug 1677625

(Firefox :: Messaging System, defect, P1)

Description

[Emily McMinn :emcminn]

The refactor of ASRouter caused a couple workarounds we were using to access the What's New Panel in devtools to break. I'll fix them here.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1673733 - Fixes and improvements to WNPanel devtools, plus tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44ecb24fe710
Fixes and improvements to WNPanel devtools, plus tests r=mconley

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/44ecb24fe710

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

Hey @Emily,

I've started to verify this issue by doing the following:

1. I've set the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref value to "true".
2. I've set the "ui.popup.disable_autohide" pref value to "true".
3. I've opened the "about:newtab#devtools-wnpanel" page.

Having the above setup, I've observed the following:

1. If I click the "Open What's New Panel" button, the "What's New" button is displayed in the top right corner, but the panel is not opened unless I click the "What's New" button.
2. If I've rendered a selected message successfully and I click the "Reset Panel", the panel remains open and the edited JSON remains displayed until I manually close the "What's New" panel.

@Emily, can you please weigh in on these 2 observations?

Comment 5

[Emily McMinn :emcminn]

Hi @romartin; it looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1673109 that landed just after this one changed a window reference, which broke these buttons again! I'll reopen the bug and take a look. Thanks!