Closed Bug 1673742 Opened 4 years ago Closed 4 years ago

Intermittent <something> | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed
firefox88 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: florian)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell needswork:owner])

Attachments

(1 file)

Bug 1673742 - browser_save_video_frame.js should clear the mockTransferCallback before resolving the waitForTransferComplete promise, r=mconley.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=319899046&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EBanYa07QZyUICTBmCQqpw/runs/0/artifacts/public/logs/live_backing.log

[task 2020-10-27T17:57:15.034Z] 17:57:15     INFO - TEST-START | browser/base/content/test/general/browser_search_discovery.js
[task 2020-10-27T17:57:15.115Z] 17:57:15     INFO - TEST-INFO | started process screencapture
[task 2020-10-27T17:57:15.201Z] 17:57:15     INFO - TEST-INFO | screencapture: exit 0
[task 2020-10-27T17:57:15.201Z] 17:57:15     INFO - Buffered messages logged at 17:57:15
[task 2020-10-27T17:57:15.201Z] 17:57:15     INFO - Entering test bound 
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - Test search discovery
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - Buffered messages finished
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_search_discovery.js | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js:39:7
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - MTFC_onStateChange@chrome://mochitests/content/browser/toolkit/content/tests/browser/common/mockTransfer.js:46:27
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - DownloadListener/makeClosure/<@chrome://global/content/contentAreaUtils.js:133:22
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - 
[task 2020-10-27T17:57:15.202Z] 17:57:15     INFO - Stack trace:
[task 2020-10-27T17:57:15.203Z] 17:57:15     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:2089
[task 2020-10-27T17:57:15.203Z] 17:57:15     INFO - chrome://global/content/contentAreaUtils.js:DownloadListener/makeClosure/<:133
[task 2020-10-27T17:57:15.203Z] 17:57:15     INFO - GECKO(1313) | JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js, line 39: ReferenceError: ok is not defined
[task 2020-10-27T17:57:15.203Z] 17:57:15     INFO - Not taking screenshot here: see the one that was previously logged```
See Also: → 1675432
Severity: normal → --
Priority: P5 → --
Summary: Intermittent browser/base/content/test/general/browser_search_discovery.js | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js → Intermittent macOS browser/base/content/test/general/browser_search_discovery.js | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/
Component: General → Mochitest
Product: Firefox → Testing
Summary: Intermittent macOS browser/base/content/test/general/browser_search_discovery.js | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/ → Intermittent macOS <something> | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/
Summary: Intermittent macOS <something> | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/ → Intermittent <something> | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/

Update:

There have been 32 failures within the last 7 days on OS X 10.14 WebRender opt.

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=328264517&repo=autoland&lineNumber=2131

[task 2021-01-30T00:19:55.340Z] 00:19:55 INFO - TEST-OK | browser/base/content/test/general/browser_save_video_frame.js | took 978ms
[task 2021-01-30T00:19:55.361Z] 00:19:55 INFO - checking window state
[task 2021-01-30T00:19:55.385Z] 00:19:55 ERROR - GECKO(2330) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js:39:7
[task 2021-01-30T00:19:55.385Z] 00:19:55 INFO - GECKO(2330) | MTFC_onStateChange@chrome://mochitests/content/browser/toolkit/content/tests/browser/common/mockTransfer.js:46:27
[task 2021-01-30T00:19:55.385Z] 00:19:55 INFO - GECKO(2330) | DownloadListener/makeClosure/<@chrome://global/content/contentAreaUtils.js:152:22
[task 2021-01-30T00:19:55.385Z] 00:19:55 INFO - GECKO(2330) | JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js, line 39: ReferenceError: ok is not defined
[task 2021-01-30T00:19:55.386Z] 00:19:55 ERROR - GECKO(2330) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]'[JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]' when calling method: [nsITransfer::onStateChange] at DownloadListener/makeClosure/<@chrome://global/content/contentAreaUtils.js:152:22
[task 2021-01-30T00:19:55.386Z] 00:19:55 INFO - GECKO(2330) | JavaScript error: chrome://global/content/contentAreaUtils.js, line 152: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]'[JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]' when calling method: [nsITransfer::onStateChange]
[task 2021-01-30T00:19:55.386Z] 00:19:55 INFO - TEST-START | browser/base/content/test/general/browser_search_discovery.js

Whiteboard: [stockwell needswork:owner]

There are 32 total failures in the last 7 days on

[task 2021-02-14T07:09:02.059Z] 07:09:02 INFO - TEST-START | browser/base/content/test/general/browser_save_video_frame.js
[task 2021-02-14T07:09:02.091Z] 07:09:02 INFO - GECKO(5492) | JavaScript error: chrome://browser/content/places/browserPlacesViews.js, line 131: Error: No DOM node set for aPlacesNode.
[task 2021-02-14T07:09:02.092Z] 07:09:02 INFO - GECKO(5492) | node.type: 0. node.parent: [xpconnect wrapped nsINavHistoryResultNode]
[task 2021-02-14T07:09:02.192Z] 07:09:02 INFO - GECKO(5492) | _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
[task 2021-02-14T07:09:02.440Z] 07:09:02 INFO - GECKO(5492) | MEMORY STAT | vsize 8325MB | residentFast 671MB | heapAllocated 207MB
[task 2021-02-14T07:09:02.440Z] 07:09:02 INFO - TEST-OK | browser/base/content/test/general/browser_save_video_frame.js | took 385ms
[task 2021-02-14T07:09:02.440Z] 07:09:02 INFO - checking window state
[task 2021-02-14T07:09:02.442Z] 07:09:02 ERROR - GECKO(5492) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - ReferenceError: ok is not defined at mockTransferCallback@chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js:39:7
[task 2021-02-14T07:09:02.442Z] 07:09:02 INFO - GECKO(5492) | MTFC_onStateChange@chrome://mochitests/content/browser/toolkit/content/tests/browser/common/mockTransfer.js:46:27
[task 2021-02-14T07:09:02.442Z] 07:09:02 INFO - GECKO(5492) | DownloadListener/makeClosure/<@chrome://global/content/contentAreaUtils.js:152:22
[task 2021-02-14T07:09:02.442Z] 07:09:02 INFO - GECKO(5492) | JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js, line 39: ReferenceError: ok is not defined
[task 2021-02-14T07:09:02.444Z] 07:09:02 ERROR - GECKO(5492) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]'[JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]' when calling method: [nsITransfer::onStateChange] at DownloadListener/makeClosure/<@chrome://global/content/contentAreaUtils.js:152:22
[task 2021-02-14T07:09:02.444Z] 07:09:02 INFO - GECKO(5492) | JavaScript error: chrome://global/content/contentAreaUtils.js, line 152: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]'[JavaScript Error: "ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_save_video_frame.js" line: 39}]' when calling method: [nsITransfer::onStateChange]
Aryx do you know who can take a look at this until ahal is back?

Flags: needinfo?(aryx.bugmail)

This test framework issue only affects macOS opt. Joel, any idea why?

Flags: needinfo?(aryx.bugmail)

I looked around at a a few errors and a few files of the test and support files, there is nothing OS specific that I see. Likewise the manifest doesn't seem to indicate tests that only run on a specific OS.

A few thoughts:

  1. the OS integration code for clicking and switching focus is glitchy on OSX vs other platforms and these tests expose that
  2. maybe there is a skipped test on OSX which on other platforms sets the browser up for success
  3. can we reproduce this on try? If we can, can we disable a test or two and see the problem go away or does it move elsewhere?
Flags: needinfo?(jmaher)
Flags: needinfo?(ahal)

Looks like the issue is confined to browser/base/content/test/general/browser_search_discovery.js, though I can't make sense of the log. Kris, I found your name in annotate for that test, do you have any ideas on what's happening in this log?
https://treeherder.mozilla.org/logviewer?job_id=331436921&repo=autoland&lineNumber=2639

Or could you help us redirect to someone else? Thanks!

Flags: needinfo?(ahal) → needinfo?(kmaglione+bmo)

I haven't done anything significant with browser_search_discovery.js. My name is only in the log because it was hit by a scripted rewrite that I landed.

That said, the issue is with the browser_save_video_frame.js test which runs before browser_search_discovery.js in the same session. The test completes before some async transfer code completes, and tries to call a callback after the test has completed, at which point the test harness functions have been cleared.

Flags: needinfo?(kmaglione+bmo)

Excellent, thanks for investigating Kris.

<game show host>Mike Conley come on down!</game show host>

Found your name in annotate for browser_save_video_frame.js. Given :kmag's comment would you be able to help fix or help find someone to fix this intermittent? Thanks in advance!

Component: Mochitest → General
Flags: needinfo?(mconley)
Product: Testing → Firefox
Assignee: nobody → florian
Status: NEW → ASSIGNED

I investigated this as I thought that failure was due to the patches in my try run.

Flags: needinfo?(mconley)
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5cacf542059 browser_save_video_frame.js should clear the mockTransferCallback before resolving the waitForTransferComplete promise, r=mconley.

Awesome, thanks Florian!

https://hg.mozilla.org/mozilla-central/rev/e5cacf542059

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: