Add CC subcategories to the "GC / CC" profiler category
Categories
(Core :: XPCOM, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
(Wait, what happened to my description? I even submitted this bug via the regular bugzilla web UI! Wtf?)
As can be seen in eg bug 1673457, it would be helpful to have profiler markers for the various parts of a CC. Especially since we have the GC broken down, it is deceptive when looking at a profile and you see a long CC followed by a long (but nicely incremental) GC. It is very easy to assume that the pause is due to a long-running GC slice. If the CC phases had markers, then it would be much easier to distinguish them.
But as I'm commenting on https://github.com/firefox-devtools/profiler/issues/3011 I am realizing that it would be even more useful to have a toplevel "CC" marker similar to the "GCMajor" marker. Can markers nest more than one level? Because it would naturally be
- GC/CC
- CC
- ForgetSkippable
- CC
but if we need to flatten things to two levels that would be ok.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
My first cut at this still had "(Other)" as the largest category, which seems avoidable.
I'm also adding some categories that might be too small to be worthwhile? eg SUBCATEGORY(GCCC, GCCC_CollectWhite, "CC (Collect White)") seems like it's rather fast. But I'm not sure what's what, so I'll let my reviewer tell me what to take out.
|
|
Assignee | |
Comment 3•5 years ago
|
||
(The uploaded patch adds an additional SUBCATEGORY(GCCC, GCCC_Finalize, "CC (Finalize)"), which I'm hopeful will absorb most of the "(Other)". But I haven't managed to build and run with it yet. Not to mention that the browser crashes if I look wrong at the profiler UI in a debug build.)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•