Closed Bug 1673790 Opened 1 year ago Closed 1 year ago

Split `HTMLEditSubActionHandler.cpp` to 3 files

Categories

(Core :: DOM: Editor, task, P1)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Although still bug 1659402 is open, we should split HTMLEditSubActionHandler.cpp ASAP due to too big (15k lines).

One should have ListElementSelectionState, ListItemElementSelectionState, AlignStateAtSelection, ParagraphStateAtSelection. Perhaps, the file name should be HTMLEditorState.cpp.

Next should have HTMLEditor::HandleDeleteSelection(), HTMLEditor::HTMLEditor::ComputeTargetRanges() and their helper stack only classes. Perhaps, the file name should be HTMLEditorDeleteHandler.cpp.

The others should remain in current file.

It's too big (+15k lines) and there are 2 groups which does not depend on the
others. One is getting current state for Document.queryCommandState etc.
This is copied to HTMLEditorState.cpp. And the other is delete handlers.
This is copied to HTMLEditorDeleteHandler.cpp.

FYI: HTMLEditorDeleteHandler.cpp has some HTMLEditor methods which are used only when handling the deletion in the file (may be called via WSRunObject.cpp though).

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/dcb0a318d44d
Split `editor/libeditor/HTMLEditSubActionHandler.cpp` r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.