1673795 - Integrate sync ping shutdown handling with TelemetryController and record if a sync shutdown ping was sent

Status: RESOLVED FIXED

(Data Platform and Tools :: General, enhancement, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

See bug 1663573 comment 11 and bug 1663573 comment 12 for more details.

I'm about to post a minimal, straw-man patch. We could go a lot further than this (all the way to moving sync's telemetry.js into the telemetry directories), or could try and make it even more general (eg, allow this for an arbitrary number of "external" pings) but I don't think we actually need much more than this - but let me know what you think!

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1673795 - Integrate sync ping shutdown handling with TelemetryController and record if a sync shutdown ping was sent. r?chutten

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: data-review.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9184705 [details]
data-review.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 90.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :markh is responsible for renewing or removing the collection before it expires in Firefox 90.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffeebb5c7d51
Integrate sync ping shutdown handling with TelemetryController and record if a sync shutdown ping was sent. r=chutten

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ffeebb5c7d51

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1673795 - don't fail test_SyncPingIntegration.js test for Thunderbird. r=chutten

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4adb485516b
don't fail test_SyncPingIntegration.js test for Thunderbird. r=chutten

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b4adb485516b

Comment 9

[Intermittent Failures Robot]

13 failures in 4128 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 13

Platform breakdown:

• macosx1014-64: 2
• windows10-64: 2
• linux64: 1
• linux64-shippable: 1
• windows7-32: 2
• windows10-64-shippable: 2
• windows7-32-shippable: 2
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1673795&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 10

[Andra Esanu (needinfo me)]

== Change summary for alert #27548 (as of Sat, 07 Nov 2020 08:29:36 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	Heap Unclassified		windows10-64-shippable-qr		59,323,231.50 -> 56,676,399.31
3%	Heap Unclassified		linux1804-64-shippable	tp6	88,926,149.03 -> 86,230,613.36
2%	Explicit Memory		linux1804-64-shippable		366,447,339.05 -> 358,279,230.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27548