1673797 - urlbar page action icons missing

Status: ASSIGNED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[lilydjwg]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

start up nightly

Actual results:

The page action icons in urlbar is missing: there is only the three-dot icon, and sometimes the reader mode icon appears. But no other icons. Clicking on the three-dot icon I see an empty popup.

Expected results:

I remember there should be a few icons by default, and in my daily use I have some more icons added by addons.

This starts to happen recently and often but not always. Sometimes those icons appear without problems. This happens with a newly-created profile but doesn't happen with mozregression.

Comment 1

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Hi,

I have tested your issue on Release version 82.0.2, Beta 83.0b7 and latest Nightly 84.0a1 (2020-11-02) using Ubuntu 18.04 and Windows 10 but could not reproduce it.
Further, I will move this over to a component so developers can take a look over it. If this is not the correct component please feel free to change it to an appropriate one.

Thanks for the report.

Comment 2

[Drew Willcoxon :adw]

Are there any errors in the browser console when you start up Firefox, open a new Firefox window, or click the three-dots button?

Comment 3

[lilydjwg]

No errors when clicking the three-dots button.

New window logs:

11:46:57.199 按键事件不存在于某些键盘布局：key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode” browser.xhtml
11:46:57.238 NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create] FileUtils.jsm:88
11:46:57.281 NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create] FileUtils.jsm:88
11:46:57.319 can't access property "setDisabled", this.action is undefined browser-pageActions.js:1265
11:46:57.320 Uncaught TypeError: can't access property "setDisabled", this.action is undefined
    updateEngines chrome://browser/content/browser-pageActions.js:1265
    updateOpenSearchBadge chrome://browser/content/browser.js:4306
    asyncUpdateUI chrome://browser/content/browser.js:5511
    onLocationChange chrome://browser/content/browser.js:5453
browser-pageActions.js:1265:5
11:46:57.444 Cannot initialize search service, bailing out: TypeError: can't access property "setDisabled", this.action is undefined searchbar.js:130

Startup logs (a new profile, first run):

1604375261784	[e-mail]	WARN	Loading extension '[e-mail]': Reading manifest: Invalid extension permission: mozillaAddons
1604375261784	[e-mail]	WARN	Loading extension '[e-mail]': Reading manifest: Invalid extension permission: telemetry
1604375261784	[e-mail]	WARN	Loading extension '[e-mail]': Reading manifest: Invalid extension permission: resource://pdf.js/
1604375261784	[e-mail]	WARN	Loading extension '[e-mail]': Reading manifest: Invalid extension permission: about:reader*
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 684"  data: no] L10nRegistry.jsm:684:19
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 684"  data: no] 2 L10nRegistry.jsm:684:19
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create] FileUtils.jsm:88
Unknown category for SetEventRecordingEnabled: fxmonitor
SearchSettings: get: No settings file exists, new profile? 
Object { operation: "open", path: "/home/lilydjwg/tmpfs/tmp/search.json.mozlz4", unixErrno: 2, stack: "", fileName: "(unknown module)", lineNumber: undefined }
SearchSettings.jsm:109:18
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create] FileUtils.jsm:88
Uncaught TypeError: can't access property "setDisabled", this.action is undefined
    updateEngines chrome://browser/content/browser-pageActions.js:1265
    updateOpenSearchBadge chrome://browser/content/browser.js:4306
    asyncUpdateUI chrome://browser/content/browser.js:5511
    onLocationChange chrome://browser/content/browser.js:5453
browser-pageActions.js:1265:5
can't access property "setDisabled", this.action is undefined 2 browser-pageActions.js:1265
No messages returned from https://snippets.cdn.mozilla.net/6/Firefox/84.0a1/20201031210517/Linux_x86_64-gcc3/zh-CN/nightly/Linux%205.9.2-arch1-1%20(GTK%203.24.23%2Clibpulse%2013.99.0)/default/default/. 2 ASRouter.jsm:120
debuggee 'resource://devtools/shared/base-loader.js:289' would run 5 builtin-modules.js:196:11

Comment 4

[Drew Willcoxon :adw]

Thanks, those errors definitely show that something's going wrong in the page actions code. It looks like the addSearchEngine action doesn't exist or hasn't been added, which doesn't make sense because it's a built-in action that's added by default. I looked through that code briefly and I don't see how that's possible, but I'll try to take a closer look.

Are you using a distribution build of Firefox?

Do the search engines work? Are you able to do searches from the urlbar and search bar?

Comment 5

[lilydjwg]

I'm using the build from Mozilla (repackaged so that the system package manager manages it). It's the zh-CN variant but reproduced with en-US one too. Builtin update is disabled and two prefs are added by default:

pref("intl.locale.requested", "");
pref("spellchecker.dictionary_path", "/usr/share/hunspell");

Searching from urlbar works and I didn't try the search bar.

It seems that when I upgrade to a new nightly (2020-11-02), the issue likely stops appearing for some time (about one or two days).... I upgraded yesterday and currently I'm again unable to reproduce it. For at least three times I thought it was gone, but only to come back later.

When it reproduces on my daily profile, I can reproduce with a newly-created profile too. I don't know how they are related.

Comment 6

[lilydjwg]

And I have the search bar added to the overflow menu (>>) though I haven't used it for long.

Comment 7

[lilydjwg]

It comes back. I see it first with the test profile, and after a restart it happens to my daily profile too.

Search bar works too.

I've enabled browser toolbox and looked into it. The PageActions.actionForID("addSearchEngine") is undefined because the PageActions._actionsByID map is empty. _deferredAddActionCalls has three items. I manually call PageActions.init() and then those missing icons are back. However after a restart, they are still missing.

Comment 8

[lilydjwg]

That nsIFile.create error on startup is suspicious. Here is its call stack:

NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.create] FileUtils.jsm:88
    FileUtils_getDir resource://gre/modules/FileUtils.jsm:88
    getUpdateDirCreate resource://gre/modules/UpdateService.jsm:838
    getUpdatesDir resource://gre/modules/UpdateService.jsm:919
    AUS__checkForBackgroundUpdates resource://gre/modules/UpdateService.jsm:2856
    AUS_checkForBackgroundUpdates resource://gre/modules/UpdateService.jsm:2723
    _checkForOldBuildUpdates resource:///modules/BrowserGlue.jsm:1449
    BG__onFirstWindowLoaded resource:///modules/BrowserGlue.jsm:1881
    BG_observe resource:///modules/BrowserGlue.jsm:1041
    _delayedStartup chrome://browser/content/browser.js:2201
    _delayedStartup self-hosted:1161

Nightly is trying to visit files under /opt/firefox-nightly/updates despite autoupdate has been disabled with the DisableAppUpdate policy. It fails with various errors because nightly doesn't have write permissions under that path.