Closed Bug 1673884 Opened 4 years ago Closed 4 years ago

Trace logged when reaching MAX_ATTEMPTS in MarionetteFrameProxy throws

Categories

(Remote Protocol :: Marionette, defect, P3)

Default
defect

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

In bug 1671347, I added a trace when the proxy reaches the maximum amount of attempts:

                logger.trace(
                  `[${this.browsingContext.id}] Query "${methodName}" reached the limit of retry attempts (${MAX_ATTEMPTS})`
                );

However this.browsingContext.id is not defined in this context and the trace will fail if we ever reach it.

Attachment #9184267 - Attachment description: Bug 1673884 - [marionette] Fix MAX_ATTEMPTS trace in MarionetteFrameActorProxy → Bug 1673884 - [marionette] Fix MAX_ATTEMPTS trace log in MarionetteFrameActorProxy
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4f3628b57a2
[marionette] Fix MAX_ATTEMPTS trace log in MarionetteFrameActorProxy r=marionette-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: