1673962 - Canceling the experimental features Restart Required prompt showed an infinite loop of prompts

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

I saw this in the wild when canceling the restart prompt after enabling Fission a few days ago but haven't been able to reproduce it anymore. I am wondering if there was another pref that was getting toggled and the two were in competition with each other.

I have written a test to reproduce it and the test is passing. We could land this new test and update it as needed if we find better steps to reproduce.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1673962 - Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jaws, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac717cd03a6b
Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset ac717cd03a6b (Bug 1673962) for causing failures in browser_experimental_features_restart_required_cancel.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=GRdiOkutQa62PUwqcpbJ8w.1&resultStatus=testfailed%2Cbusted%2Cexception&revision=ac717cd03a6b0575558df57d4cfd0f724698d811

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321925019&repo=autoland&lineNumber=5326

Backout: https://hg.mozilla.org/integration/autoland/rev/54c5f5fb77b7c82bdee8748366b09382084b2bd8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac3e7350aeed
Test to cover the code path of canceling the Restart Required prompt when enabling a restart-required=true experimental feature. r=Gijs,preferences-reviewers

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_experimental_features_restart_required_cancel.js

backout: https://hg.mozilla.org/integration/autoland/rev/d0ecb44f9412a84d48fbfaaee1e4240064de4825

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ac3e7350aeedcc29bfe79720c2b9097a54600a15&selectedTaskRun=bkS1D_e1Rb2E96_FyL-l0w.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=321959505&repo=autoland&lineNumber=8475

[task 2020-11-16T22:07:15.179Z] 22:07:15 INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_restart_required_cancel.js | Checkbox should exist -
[task 2020-11-16T22:07:15.179Z] 22:07:15 INFO - Buffered messages finished
[task 2020-11-16T22:07:15.179Z] 22:07:15 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_restart_required_cancel.js | Cancel button should exist in dialog -
[task 2020-11-16T22:07:15.180Z] 22:07:15 INFO - Stack trace:
[task 2020-11-16T22:07:15.180Z] 22:07:15 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-16T22:07:15.180Z] 22:07:15 INFO - chrome://mochitests/content/browser/browser/components/preferences/tests/browser_experimental_features_restart_required_cancel.js:testInfiniteCancelLoop:40
[task 2020-11-16T22:07:15.181Z] 22:07:15 INFO - resource:///actors/PromptParent.jsm:openChromePrompt:283
[task 2020-11-16T22:07:15.181Z] 22:07:15 INFO - resource:///actors/PromptParent.jsm:receiveMessage:127
[task 2020-11-16T22:07:15.181Z] 22:07:15 INFO - resource://gre/modules/Prompter.jsm:openPrompt:1183
[task 2020-11-16T22:07:15.182Z] 22:07:15 INFO - resource://gre/modules/Prompter.jsm:openPromptSync:1071
[task 2020-11-16T22:07:15.182Z] 22:07:15 INFO - resource://gre/modules/Prompter.jsm:confirmEx:1450
[task 2020-11-16T22:07:15.182Z] 22:07:15 INFO - resource://gre/modules/Prompter.jsm:confirmEx:298
[task 2020-11-16T22:07:15.183Z] 22:07:15 INFO - chrome://browser/content/preferences/preferences.js:confirmRestartPrompt:472
[task 2020-11-16T22:07:15.183Z] 22:07:15 INFO - Not taking screenshot here: see the one that was previously logged

Comment 7

[nayinain]

Attachment: Capture 2020-11-17 22-44-11.webm

I can reproduce this issue:

1. Open about:preferences#experimental.
2. Duplicate the Tab.
3. Enable Fission.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to nayinain from comment #7)

Created attachment 9188307 [details]
Capture 2020-11-17 22-44-11.webm

I can reproduce this issue:

1. Open about:preferences#experimental.
2. Duplicate the Tab.
3. Enable Fission.

Thank you!