Closed Bug 1673996 Opened 4 years ago Closed 4 years ago

Downloads toolbar icon/progress indicator disappeared after a successful download

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: nalexander, Unassigned)

Details

(Keywords: regressionwindow-wanted)

After downloading a DMG, the download toolbar icon/progress indicator disappeared. The button could still be pressed/right clicked, and it got styling when it was hovered over. Gijs suggested I peek at the CSS styles using the Browser Toolbox and I saw that the toolbar icon did have a list-style-image style applied. Navigating to the chrome URL (namely chrome://browser/skin/downloads/download-icons.svg#arrow-with-bar) did display the expected SVG in the browser. Based on this, Gijs suggested this is more likely to be a layout/graphics/imglib issue than a CSS or front-end issue.

After downloading again, the progress indicator showed and then went away to reveal the "full blue" download arrow. Clicking and then clicking again restored the gray icon.

I am using Nightly 84, build ID 20201026092834, on macOS. WebRender is enabled; I have not opted in to software WR.

The relevant CSS rule was

#downloads-button {
	list-style-image: url("chrome://browser/skin/downloads/download-icons.svg#arrow-with-bar");
}

The outer HTML of the relevant element was

<toolbarbutton xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="downloads-button" class="toolbarbutton-1 chromeclass-toolbar-additional" badged="true" key="key_openDownloads" onmousedown="DownloadsIndicatorView.onCommand(event);" onkeypress="DownloadsIndicatorView.onCommand(event);" ondrop="DownloadsIndicatorView.onDrop(event);" ondragover="DownloadsIndicatorView.onDragOver(event);" ondragenter="DownloadsIndicatorView.onDragOver(event);" label="Downloads" removable="true" overflows="false" cui-areatype="toolbar" tooltip="dynamic-shortcut-tooltip" indicator="true">
  <stack class="toolbarbutton-badge-stack">
    <stack id="downloads-indicator-anchor" consumeanchor="downloads-button">
      <box id="downloads-indicator-icon"/>
      <stack id="downloads-indicator-progress-outer">
        <box id="downloads-indicator-progress-inner" style="animation-delay: 1s;"/>
      </stack>
    </stack>
    <image class="toolbarbutton-icon" label="Downloads"/>
    <html:label xmlns:html="http://www.w3.org/1999/xhtml" class="toolbarbutton-badge">
    </html:label>
  </stack>
  <label class="toolbarbutton-text" crop="right" flex="1" value="Downloads"/>
</toolbarbutton>

I was able to reproduce this today - with slightly different results. I started a download and the toolbar made space for the download arrow, but there was nothing visible. Shortly after, when the download completed the download icon appeared as it animated.

Hi,

I will move this over to a component. If this is not the correct component please feel free to change it to an appropriate one.

Thanks.

Component: Untriaged → Downloads Panel

(In reply to Nick Alexander :nalexander [he/him] from comment #0)

Gijs suggested I peek at the CSS styles using the Browser Toolbox and I saw that the toolbar icon did have a list-style-image style applied. Navigating to the chrome URL (namely chrome://browser/skin/downloads/download-icons.svg#arrow-with-bar) did display the expected SVG in the browser. Based on this, Gijs suggested this is more likely to be a layout/graphics/imglib issue than a CSS or front-end issue.

--> moving to graphics.

Component: Downloads Panel → Graphics
Product: Firefox → Core

Is there more info on how to reproduce this? I tried to reproduce with the latest nightly on macOS a couple times and it seemed to work fine. I have webrender enabled like the reporter mentioned.

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Is there more info on how to reproduce this? I tried to reproduce with the latest nightly on macOS a couple times and it seemed to work fine. I have webrender enabled like the reporter mentioned.

No, and I can no longer reproduce. It seems like it was a transient (but inspectable) situation. I'll resolve this as WORKSFORME; if it occurs again, we can always reopen.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.