The range thumb should have a shadow in the basic theme
Categories
(Core :: Widget, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(2 files)
screenshot with patch
Spec: https://mozilla.invisionapp.com/share/5CX2MH6EHFB#/screens/415584863_Form_Widgets
Testcase: http://stephenhorlander.com/form-controls.html
(with widget.disable-native-theme-for-content set to true)
On range controls, the spec calls for a shadow under the range thumb. We currently do not draw one.
|
Assignee | |
Comment 1•4 years ago
|
||
What's implemented in this patch doesn't match the spec to 100%, but it comes
pretty close. This patch is cutting two corners: We're only using one shadow
instead of two, and we're using a smaller blur radius (2 instead of 2 and 4).
Both adjustments are done to improve performance; blurring is a computationally
expensive operation, so we should minimize its cost.
As the shadow color, I'm using a transparent black instead of a transparent
gray, because this makes it easier to do the blurring on an A8 surface rather
than on a full RGBA surface, given the current Moz2D API.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/4db2fb0f178c Draw a shadow under the range thumb in the basic theme. r=spohl
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•