Closed
Bug 1674121
Opened 5 years ago
Closed 5 years ago
Unused state for Picture-in-Picture toggle is missing padding
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
VERIFIED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox82 | --- | unaffected |
| firefox83 | --- | unaffected |
| firefox84 | --- | verified |
| firefox85 | --- | verified |
People
(Reporter: mconley, Assigned: jack1391)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
image.png
See screenshot - there's missing whitespace on either side of the icon and "Watch in Picture-in-Picture" string.
I believe this is fallout from bug 1670254.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → jack1391
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a6d8aed67f4
Fix missing padding on Picture-in-Picture toggle button. r=mconley
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
|
||
Comment 4•5 years ago
|
||
Set release status flags based on info from the regressing bug 1670254
status-firefox82:
--- → unaffected
status-firefox83:
--- → unaffected
status-firefox-esr78:
--- → unaffected
|
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Updated•5 years ago
|
QA Whiteboard: [qa-84b-p2]
|
||
Comment 5•5 years ago
•
|
||
I managed to reproduce the issue using an older version of Nightly on Windows 10 x64. I retested everything on macOS 10.13, Ubuntu 18.04 and Windows 10 x64 using Firefox 84.0 and Nightly 85.0a1. The issue is not reproducing anymore.
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•