1674140 - Crash in [@ mozilla::net::WebrtcTCPSocket::Write]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Sean Feng [:sefeng]]

Crash report: https://crash-stats.mozilla.org/report/index/109959c9-d17b-4939-8d69-973ca0201028

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (NS_SUCCEEDED(mSocketThread->Dispatch(NewRunnableMethod<nsTArray<uint8_t>&&>( "WebrtcTCPSocket::Write", this, &WebrtcTCPSocket::EnqueueWrite_s, std::move(aWriteData)))))

Top 10 frames of crashing thread:

0 XUL mozilla::net::WebrtcTCPSocket::Write dom/media/webrtc/transport/ipc/WebrtcTCPSocket.cpp:83
1 XUL mozilla::net::WebrtcTCPSocketParent::RecvWrite dom/media/webrtc/transport/ipc/WebrtcTCPSocketParent.cpp:41
2 XUL mozilla::net::PWebrtcTCPSocketParent::OnMessageReceived ipc/ipdl/PWebrtcTCPSocketParent.cpp:273
3 XUL mozilla::net::PSocketProcessParent::OnMessageReceived ipc/ipdl/PSocketProcessParent.cpp:2125
4 XUL mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074
5 XUL mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1953
6 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:515
7 XUL mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal xpcom/threads/nsThreadUtils.h:577
8 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1197
9 XUL nsThread::Shutdown xpcom/threads/nsThread.cpp:898

Low frequent crash. Filing because it violated the expectation.

Comment 1

[Michael Froman [:mjf]]

:bwc Is this something you can take a look at?

Comment 2

[Byron Campen [:bwc]]

Looks like a shutdown crash. It is probably appropriate to remove the assertion, and replace with NS_WARN_IF.

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05560474d9237cdd4ccd3acf09b1e49c783ab98c

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64afb71216595ba3608ab491b89ce891c1373103

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1674140: Don't crash when we cannot dispatch to STS, since that can happen during shutdown. r?mjf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/966c3db66902
Don't crash when we cannot dispatch to STS, since that can happen during shutdown. r=mjf

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/966c3db66902