1674144 - More toolbarbutton-1 unifying

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

There are still some improvements to the unifying of .toolbarbutton-1 possible.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1674144-more-toolbarbutton-1-unifying.patch

I moved more rules to the shared messenger.css. Now there should be no rule that can be shared. I also cleaned some OS special rules to make them the same on all platforms.

I also updated how the active menu-buttons look with the dark theme. Before they used the checked appearance which looked a bit weird and inconsistent to the dropmarker which still used the active background. I don't think that we need to have enough contrast when clicking the button. The user should have read the button text before he clicks it.

Comment 2

[Alessandro Castellani [:aleca]]

I also updated how the active menu-buttons look with the dark theme. Before they used the checked appearance which looked a bit weird and inconsistent to the dropmarker which still used the active background. I don't think that we need to have enough contrast when clicking the button. The user should have read the button text before he clicks it.

I'm not sure about this.
It looks a bit weird that some buttons get a dark background when clicked/checked, while the menu-buttons get a light background.
I think we should do the opposite and let the dropdown part of the menu-button get the similar dark background for when the button is clicked.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #2)

It looks a bit weird that some buttons get a dark background when clicked/checked, while the menu-buttons get a light background.
I think we should do the opposite and let the dropdown part of the menu-button get the similar dark background for when the button is clicked.

Can you show me an example of this two behaviours?

Comment 4

[Alessandro Castellani [:aleca]]

Can you show me an example of this two behaviours?

Ah no, you're right, with your patch the dark background is only for checked buttons, and a lighter background is used for clicked/active.
I think that's fine as the clicked action is only a split second, and a lighter visual feedback stands out more.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9184533 [details] [diff] [review]
1674144-more-toolbarbutton-1-unifying.patch

Review of attachment 9184533 [details] [diff] [review]:
-----------------------------------------------------------------

Can you update the commit message to:
"Bug 1674144 - More toolbarbutton-1 style unification and improvement of active state for dark mode. r=aleca"

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1674144-more-toolbarbutton-1-unifying.patch

Updated the commit message.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/77b64c86f9f5
More toolbarbutton-1 style unification and improvement of active state for dark mode. r=aleca