1674214 - Track FX_NUMBER_OF_UNIQUE_SITE_ORIGINS high water mark for Linux users

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P1)

Description

[Chris Peterson [:cpeterson]]

We'd like to enroll Linux Nightly users who have an existing (non-new) profile (check profile age?) and have not opened more than 30 unique site origins simultaneously in the last 15 days.

We'll need to monitor the high water mark of the FX_NUMBER_OF_UNIQUE_SITE_ORIGINS telemetry probe over the last 15 days. If the high water mark ever exceeds 30 origins, the client should be unenrolled from the experiment.

mythmon recommends writing the state to a pref. The pref doesn't need to be statically defined (in all.js or firefox.js) or defined for all users. So we only need to set it for Linux users.

The browser.laterrun.bookkeeping.profileCreationTime pref is the number of seconds since the Unix epoch (1970-01-01):

https://searchfox.org/mozilla-central/rev/d866b96d74ec2a63f09ee418f048d23f4fd379a2/browser/modules/LaterRun.jsm#69-73

The Normandy recipe can check our origin high water mark pref and the profileCreationTime pref.

Comment 1

[Chris Peterson [:cpeterson]]

When first setting the pref, walk the telemetry history to discover the recent high water mark. If the high water mark ever exceeds 30 origins, the client should be unenrolled from the experiment.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1674214: Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47f0d542db39
Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 47f0d542db39 (Bug 1674214) for causing fission related failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=47f0d542db3907c30fa16aae0e0777d85330a348&selectedTaskRun=YqA6Y7EvSQS-pjItLdM0yQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=325888663&repo=autoland&lineNumber=1841
https://treeherder.mozilla.org/logviewer?job_id=325888821&repo=autoland&lineNumber=3380

Backout: https://hg.mozilla.org/integration/autoland/rev/6ed8cb5d735515373352ba7d3afb4476fe0d6b84

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ef22fe8f73a
Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19fbaf9cd86f
Eslint fix. r=fix CLOSED TREE

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1674214: Follow-up: Formatting fix.

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1674214) for causing failures in browser_fission_maxOrigins.js CLOSED TREE

This started failing again on tier1 here: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=fdbcd1cd62e215d916777f5ff305fbdb6c4da9ef&selectedTaskRun=WmneodTZTJ2PGxu0hMYolw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=325917512&repo=autoland&lineNumber=3274

https://hg.mozilla.org/integration/autoland/rev/c56edd7687511e3f3b3027a5e13fc9a9f0a9a48b

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/256a8293104e
Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/256a8293104e