Closed Bug 1674233 Opened 1 month ago Closed 20 days ago

Collect the Telemetry client_id in "fog-validation" pings

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: chutten|PTO, Assigned: chutten|PTO)

References

Details

Attachments

(2 files)

To properly validate whether FOG is reporting "fog-validation" pings correctly, we need to cross-link the pings with "main" pings. Since we expect to need to use the Telemetry client_id in FOG for the foreseeable future, we may as well try instrumenting it now to start working out the kinks early.

This'll be a temporary collection, and does not intend to be the one true Telemetry client_id instrumentation for FOG. It will be removed after its FOG validation purposes have been satisfied.

Attached file data collection review
Attachment #9184633 - Flags: data-review?(tdsmith)

Comment on attachment 9184633 [details]
data collection review

I believe client_id is a category 1 collection but since you've described it as category 4, let's escalate, and let me know if you expected something else :)

Alicia, can you sign off on including the Firefox telemetry client_id in a glean ping to be sent from desktop? The fog-validation ping otherwise contains only category 1 data. https://firefox-source-docs.mozilla.org/metrics/index.html

Flags: needinfo?(agray)

Approved by Trust

Flags: needinfo?(agray)

Comment on attachment 9184633 [details]
data collection review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, at https://firefox-source-docs.mozilla.org/metrics/index.html

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

It associates the client_id with a set of category 1 metrics.

  1. Is the data collection request for default-on or default-off?

Default-on.

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes.

  1. Does there need to be a check-in in the future to determine whether to renew the data?

Nope; that's up to chutten.

  1. Does the data collection use a third-party collection tool?

Nope.

Attachment #9184633 - Flags: data-review?(tdsmith) → data-review+

We want to get this in so it rides with FOG to Beta. This'll help with its secondary analysis goal as mentioned in the review: measuring profile inflation.

Blocks: 1651111
No longer blocks: 1651110
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0391bebaa3b0
Report the Telemetry client_id in FOG fog-validation pings r=janerik

Oh phooey. I guarded all the uses of the Glean global, but I didn't guard the import of the global name.

A simple fix. I'll make sure to run Android xpcshell tests on try before I push again.

Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ab8e3c5969d
Report the Telemetry client_id in FOG fog-validation pings r=janerik
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1676285
You need to log in before you can comment on or make changes to this bug.