Closed Bug 1674266 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26334 - [client-hints] Viewport-Width correct value for navigation requests

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26334 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26334
Details from upstream follow.

b'Yoav Weiss <yoavweiss@chromium.org>' wrote:

[client-hints] Viewport-Width correct value for navigation requests

Currently, Viewport-Width hints send the display width for navigation
requests, rather than the actual viewport width.
This CL fixes that for the case of new windows that have the same
viewport as their opener.

Bug: 825892
Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c
Reviewed-on: https://chromium-review.googlesource.com/2494876
WPT-Export-Revision: 4114d047d0f49109ca77bf6ab2daf42f075a3472

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
FAIL: 4

Chrome

OK : 4
PASS: 1
FAIL: 3

Safari

OK : 4
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/viewport-width-iframe.https.html
viewport-width-iframe: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/viewport-width-subresource.https.html
viewport-width-subresource: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/viewport-width-window-different-dimensions.https.html
viewport-width-window-different-dimensions: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/viewport-width-window.https.html
viewport-width-window: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf1ff4a730be
[wpt PR 26334] - [client-hints] Viewport-Width correct value for navigation requests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/eceb58fa4e0a
[wpt PR 26334] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bf1ff4a730be
https://hg.mozilla.org/mozilla-central/rev/eceb58fa4e0a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.