1674272 - Change background fill colour of Custom Images for Top Sites with transparency (Dark Theme)

Status: NEW

(Firefox :: Top Sites, defect)

Description

[Robin A. Meade]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

I added a Top Site to my New Tab page with a Custom Image URL pointing to a image that has transparency:

https://upload.wikimedia.org/wikipedia/commons/thumb/1/12/Google_Photos_icon_%282020%29.svg/240px-Google_Photos_icon_%282020%29.svg.png

Actual results:

The transparency was filled with a white colour, even though I was using the Dark theme.

Expected results:

The transparency should be filled with a dark colour, as was fixed for favicon images for Top Sites in bug 1454730.

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Hi,
I was able to reproduce it on latest Nightly version 84.0a1 (2020-11-02)(64-bit) on Ubuntu 18.04 and Windows 10 using a dark or a default theme.
I will set a component to have a starting point of this. Please if this is not the right component feel free to route this ticket to the corresponding team, thanks!

Comment 2

[Marcela (Please NI request to Brindusa Tot)]

The suggested severity revolves around S3

Comment 3

[Dzmitry Malyshau [:kvark]]

Thanks Marcela!
Andrew, does this need immediate (or quick) fix?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

I suspect this doesn't need anything from imagelib? The linked image has a transparent background so it should blend with whatever is behind it. I suppose in this case that is white.