Closed Bug 1674277 Opened 4 years ago Closed 3 years ago

Update Downloader never gets cleaned up

Categories

(Toolkit :: Application Update, defect, P3)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: bytesized, Assigned: bytesized)

Details

Attachments

(2 files)

It looks like the update downloader's cleanup function never actually gets called.

It appears that I mistakenly removed it when I was cleaning up some telemetry that was no longer being used. When I have a free moment, I want to put that call back there.

I'm concerned though that it looks like the current implementation does some asynchronous shutdown without waiting on it. That strikes me as being not correct, since if we are shutting down, we may want to wait on it now. I'll have to take a closer look when I have more time.

The Downloader's cleanup function really ought to be asynchronous. The observer for "quit-application" is already asynchronous, so there's no problem there. But really, we ought to be cleaning up each downloader that we use, not just the last one. Which means that the cleanup ought to happen in AUS.stopDownload. So this patch will convert AUS.stopDownload to be asynchronous so that we can properly clean up the downloader from there.

Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fc1b109610f
Make AUS.stopDownload asynchronous r=nalexander,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/2106af8bc297
Properly clean up the update downloader on shutdown r=nalexander
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: