about:ion does not update when add-ons status changes
Categories
(Firefox :: Pioneer, defect, P1)
Tracking
()
People
(Reporter: rhelmer, Assigned: rhelmer)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release-
|
Details | Review |
about:ion watches for add-on changes, but it is not comparing the cached vs. the add-on listener event correctly.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by rhelmer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/175036726991 about:ion should listen for add-ons status changes r=Dexter
Assignee | ||
Comment 3•4 years ago
|
||
Comment on attachment 9184673 [details]
Bug 1674282 - about:ion should listen for add-ons status changes
Beta/Release Uplift Approval Request
- User impact if declined: about:ion UI can be stale if a study add-on is removed without going through the UI
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: Note that while I said "no" to automated tests, this bug is happening because it's mocked.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): In the worst case, this failing means that the UI doesn't update (current state :))
- String changes made/needed:
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9184673 [details]
Bug 1674282 - about:ion should listen for add-ons status changes
Beta/Release Uplift Approval Request
- User impact if declined: The about:ion UI can be stale if a study add-on is uninstalled outside of the UI
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Note that while I said "no" to automated tests, this bug is happening because it's mocked.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a tiny change to the way arrays are iterated over, worst case is that the UI is stale (current state :) )
- String changes made/needed:
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Comment on attachment 9184673 [details]
Bug 1674282 - about:ion should listen for add-ons status changes
Uplift approved for 83 beta 8 as this is a minor fix and we have our last betas this week and need QA to verify on beta before RC week.
Comment 7•4 years ago
|
||
Comment on attachment 9184673 [details]
Bug 1674282 - about:ion should listen for add-ons status changes
I don't think this warrants dot release inclusion with 83 a couple of weeks away.
Updated•4 years ago
|
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 9•4 years ago
•
|
||
Hi Rob, is there a way for QA to verify this fix?
It is about the Join/Leave Study button which remains in status "Leave Study" after accept the Ion Study Privacy Consent Notice but Decline the "Your informed consent is being sought for research" page?
Thanks!
Assignee | ||
Comment 10•4 years ago
|
||
(In reply to Alin Ilea from comment #9)
Hi Rob, is there a way for QA to verify this fix?
It is about the Join/Leave Study button which remains in status "Leave Study" after accept the Ion Study Privacy Consent Notice but Decline the "Your informed consent is being sought for research" page?
Thanks!
Yes! The easy way is to Join about:ion, then join the News Disinformation Study, and remove the news disinfo extension from about:addons
Return the the already about:ion tab and it will show "leave" instead of "join" unless you reload the page.
Comment 11•4 years ago
|
||
Thanks for the answer.
I have managed to reproduce the issue in Release version 82.0.2 using Windows 10.
Verified - Fixed in latest Nightly 84.0a1 (build id: 20201104214352) and Beta 83.0b8 (build id: 20201103183834), following the steps from comment 10. There study button state turns to Join after removing the add-on without refreshing the page.
Description
•