1674315 - Excessive console errors when playing any media

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

When you to to play a video in YouTube you'll see in the JS console messages like:

Cannot play media. No decoders for requested formats: video/mp4; codecs="avc1.4d4015", video/mp4; codecs="avc1.4d401e", video/mp4; codecs="avc1.4d401f", video/mp4; codecs="avc1.4d401f", video/mp4; codecs="avc1.640028", audio/mp4; codecs="mp4a.40.2", video/mp4; codecs="avc1.4d400c", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", audio/webm; codecs="opus", audio/webm; codecs="opus", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/mp4; codecs="av01.0.00M.08", video/mp4; codecs="av01.0.00M.08", video/mp4; codecs="av01.0.01M.08", video/mp4; codecs="av01.0.04M.08", video/mp4; codecs="av01.0.05M.08", video/mp4; codecs="av01.0.08M.08", video/mp4; codecs="avc1.4d400c", video/mp4; codecs="avc1.4d401e", video/mp4; codecs="avc1.4d4014", video/mp4; codecs="avc1.4d4016", video/mp4; codecs="avc1.64001e", audio/mp4; codecs="mp4a.40.2", video/mp4; codecs="avc1.4d400b", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", audio/webm; codecs="opus", video/webm; codecs="vp09.00.51.08.01.01.01.01.00", audio/webm; codecs="opus", video/mp4; codecs="avc1.4d400b"

The issue that we have multiple PDM registering themselves with the decoderdoctor and reporting an error even though we do ultimately succeed.

Comment 1

[Jean-Yves Avenard [:jya]]

The bug is simplistic, yet I'm puzzled on how it ever worked:

If aCanPlay is true (https://searchfox.org/mozilla-central/rev/8698fade12984b9a6a43a85a287a5f17e8fd4ddf/dom/media/doctor/DecoderDoctorDiagnostics.cpp#881-885) then the code remove the flag CanPlay

And to decide if CanPlay was true, we check if the flag is set.
https://searchfox.org/mozilla-central/rev/8698fade12984b9a6a43a85a287a5f17e8fd4ddf/dom/media/doctor/DecoderDoctorDiagnostics.cpp#518-523

So this will always report the revert of what it was.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1674315 - Fix logic error to determine if playback succeeded. r?alwu,bryce

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ea9bd8b3be
Fix logic error to determine if playback succeeded. r=alwu,bryce

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/54ea9bd8b3be