1674499 - [False Negative] Password generation is not offered for the New Password field on analytics.amplitude.com

Status: RESOLVED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Matthew N. [:MattN]]

• h2 contains "Activate your account"
• field are only labelled with @placeholder
• button is labelled "Activate"

I think we can try look for "Activate" in some regexes.

Comment 1

[Matthew N. [:MattN]]

Attachment: GitHub Pull Request for fathom-login-forms

sfoster, would you mind reviewing this or delegate to Bianca/Erik? Bianca, Erik or myself can help explain the process.

Comment 2

[Sam Foster [:sfoster] (he/him)]

We sat down with Erik and reviewed this and merged the PR. Thanks for the patch and thanks Erik for your help.

Comment 3

[Matthew N. [:MattN]]

https://github.com/mozilla-services/fathom-login-forms/commit/d0866e367c9c5ac39c098ef867a23ab08c32b316

I will submit other fathom-login-forms changes before uplifting the new model in m-c.

Comment 4

[Matthew N. [:MattN]]

The model is getting uplifted in m-c in https://phabricator.services.mozilla.com/D111926

Comment 5

[Timea Cernea [:tbabos][inactive]]

NI? myself to verify this when Bug 1692980 will be landed given it should fix this issue. Reproduced it on the current affected Nightly 89.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Attachment: After Fix- still repro

This is still reproducible on my side on the latest Nightly 90.0a1 (2021-05-30) after the fix has landed for Bug 1692980.

Hi Dimi, should we re-open this issue?

Comment 7

[Dimi Lee [:dimi]]

(In reply to Timea Cernea [:tbabos] from comment #6)

Hi Dimi, should we re-open this issue?

I think yes, but I'll take a look first, keep the NI.

Comment 8

[Dimi Lee [:dimi]]

Attachment: Activate.png

Hi Timea,
From the description and the sample uploaded by MattN, I think the bug aims to address a different page than the "Finish creating your account" page.
I think we should test the "activate" page in this bug and file another bug for the "creating" page. What do you think?

Comment 9

[Timea Cernea [:tbabos][inactive]]

Submitted Bug 1714061 to handle the case for the Finish Creating and Password change form. As for this one, I am unfortunately unable to reach this flow as it seems like it needs an invitation from an admin. However, this is verified by the ML model so that should cover it.