1674533 - Unreplaced $unit variable displayed for some rows in about:processes

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

As far as I can see from the Inspector, it only happens on cells that use the string about-processes-cpu-user-and-kernel. But it's hard to confirm, given the page refreshes frequently.

Comment 1

[Francesco Lodolo [:flod]]

This is happening on macOS with an Italian build (OS set to Italian).

Interestingly enough, it doesn't seem to happen on Linux, with a local build (en-US) built on top of current default.

Comment 2

[Francesco Lodolo [:flod]]

Looks like the problem is with duration in minutes, caused by moving from min to m, but not everywhere.
https://hg.mozilla.org/mozilla-central/file/695f232f1abce34eaac99df10dbb7973b7ab6373/toolkit/components/aboutprocesses/content/aboutProcesses.js#l951

The code searches for a units.duration['m'], and returns undefined.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Thanks!

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1674533 - about:processes should use 'm' everywhere for minutes;r?florian

Comment 5

[David Teller [:Yoric] - still alive but not very active]

My first patch as an external contributor since 2011!

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1635117

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20478a1a36cb
about:processes should use 'm' everywhere for minutes;r=florian

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/20478a1a36cb