1674637 - Use nested namespaces - new feature of C++17 - second pass

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1605934 +++
Now that dom has been fixed (see bug 1626530) we can run it on more files
This replaces

namespace mozilla {
namespace a11y {

by

namespace mozilla::a11y {

I run clang-format to replace the end of the namespace:

}  // namespace Telemetry
}  // namespace mozilla

by

}  // namespace mozilla::Telemetry

Comment 1

[Sylvestre Ledru [:Sylvestre]]

to run it:

./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

clang-format is necessary because of

-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

isn't done by clang-tidy

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1674637 - Use nested namespaces in dom/ r?sg,andi

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0adbf7522dc
Use nested namespaces in dom/ r=sg,andi

Comment 4

[Atila Butkovits]

Backed out for bustage on GMPParent.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8bb104cbe0cf1e1de6688a2770281e76702bb8c9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c0adbf7522dc9daa4f17a7607c5eb45a99d08d44&searchStr=build&selectedTaskRun=RiK1R0zPS_qtgIrqmzR2qw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=320688637&repo=autoland&lineNumber=9970

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a260892acc9
Use nested namespaces in dom/ r=sg,andi

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8a260892acc9