Closed
Bug 1674637
Opened 4 years ago
Closed 4 years ago
Use nested namespaces - new feature of C++17 - second pass
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox84 fixed)
RESOLVED
FIXED
84 Branch
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1605934 +++
Now that dom has been fixed (see bug 1626530) we can run it on more files
This replaces
namespace mozilla {
namespace a11y {
by
namespace mozilla::a11y {
I run clang-format to replace the end of the namespace:
} // namespace Telemetry
} // namespace mozilla
by
} // namespace mozilla::Telemetry
Assignee | ||
Comment 1•4 years ago
•
|
||
to run it:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
clang-format is necessary because of
-} // namespace dom
-} // namespace mozilla
+} // namespace mozilla::dom
isn't done by clang-tidy
Assignee | ||
Comment 2•4 years ago
|
||
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Updated•4 years ago
|
Assignee: nobody → sledru
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c0adbf7522dc Use nested namespaces in dom/ r=sg,andi
Comment 4•4 years ago
|
||
Backed out for bustage on GMPParent.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/8bb104cbe0cf1e1de6688a2770281e76702bb8c9
Failure log: https://treeherder.mozilla.org/logviewer?job_id=320688637&repo=autoland&lineNumber=9970
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a260892acc9 Use nested namespaces in dom/ r=sg,andi
Comment 6•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(sledru)
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•