Closed Bug 1674639 Opened 11 months ago Closed 11 months ago

The toolbar border below inactive tabs with light theme is not visible

Categories

(Thunderbird :: Theme, defect)

All
Windows 10
defect

Tracking

(thunderbird_esr78 wontfix, thunderbird83 affected, thunderbird84 affected)

RESOLVED FIXED
84 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird83 --- affected
thunderbird84 --- affected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 2 obsolete files)

Attached image border-bug.png

On Windows 10 with TB's light theme the top toolbar border isn't visible below the inactive tabs.

This part was a remnant when we didn't fill the tabbar when the accent colour was set on window titles. Later we filled it with the theme background colour and this styles are no more needed.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9185037 - Flags: review?(alessandro)

Sorry, I don't currently have a working windows VM to test this. T_T
Could you redirect this review to Thomas, or maybe John?

Comment on attachment 9185037 [details] [diff] [review]
1674639-light-theme-border-below-inactive-tabs.patch

John, could you check this? You need to enable the apply the accent colour to titlebars and window borders in the Win10 prefs (Colours section.

Attachment #9185037 - Flags: review?(alessandro) → review?(john)

I could reproduce the bug and I can confirm, that the patch is fixing it. I could not see any other negative impacts.

Attachment #9185037 - Flags: review?(john) → review+

Thanks for the review. Updated the reviewer in the commit message.

Attachment #9185037 - Attachment is obsolete: true
Attachment #9185528 - Flags: review+

Hmm, it didn't get the updated reviewer.

Attachment #9185528 - Attachment is obsolete: true
Attachment #9185529 - Flags: review+
Target Milestone: --- → 84 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f2074cb87e72
Fix the toolbar border below inactive tabs with light theme. r=TbSync DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.