1674639 - The toolbar border below inactive tabs with light theme is not visible

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: border-bug.png

On Windows 10 with TB's light theme the top toolbar border isn't visible below the inactive tabs.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1674639-light-theme-border-below-inactive-tabs.patch

This part was a remnant when we didn't fill the tabbar when the accent colour was set on window titles. Later we filled it with the theme background colour and this styles are no more needed.

Comment 2

[Alessandro Castellani [:aleca]]

Sorry, I don't currently have a working windows VM to test this. T_T
Could you redirect this review to Thomas, or maybe John?

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9185037 [details] [diff] [review]
1674639-light-theme-border-below-inactive-tabs.patch

John, could you check this? You need to enable the apply the accent colour to titlebars and window borders in the Win10 prefs (Colours section.

Comment 4

[John Bieling]

I could reproduce the bug and I can confirm, that the patch is fixing it. I could not see any other negative impacts.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1674639-light-theme-border-below-inactive-tabs.patch

Thanks for the review. Updated the reviewer in the commit message.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1674639-light-theme-border-below-inactive-tabs.patch

Hmm, it didn't get the updated reviewer.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f2074cb87e72
Fix the toolbar border below inactive tabs with light theme. r=TbSync DONTBUILD