Closed
Bug 1674675
Opened 4 years ago
Closed 3 years ago
nsUpdateDriver.cpp: do not use 'else' after 'return'
Categories
(Core :: General, task)
Core
General
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: harshgup626)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1674609 +++
Filling as a good first bug to learn workflows.
do not use 'else' after 'return'
https://searchfox.org/mozilla-central/source/toolkit/xre/nsUpdateDriver.cpp#555-559
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → harshgup626
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
||
Updated•3 years ago
|
Attachment #9194743 -
Attachment description: Bug 1674675 - Readability improvements in nsUpdateDriver.cpp r=Sylvestre → Bug 1674675 - nsUpdateDriver.cpp: simplify the code by removing an else r=Sylvestre
|
|
||
Updated•3 years ago
|
Attachment #9194734 -
Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0349ccb58fc4 nsUpdateDriver.cpp: simplify the code by removing an else r=sylvestre
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•