1674694 - Change APZEventResult::mHandledByRootApzc to Maybe<APZHandledResult> from Maybe<bool>

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

In bug 1663000 we are going to introduce an enum class named APZHandledResult representing tri-state a) the event will be handled in the root APZC, b) the event will not be handled in a non root APZC, c) the event will not be handled in any APZC, and use them for deferred answer cases, but in theory it can also be used for non-deferred cases.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1674694 - Change APZEventResult::mHandledByRootApzc to Maybe<APZHandledResult>. r?botond

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1674694 - Use ConvertAPZHandledResult nsEventStatus_eConsumeNoDefault case. r?botond

In the case of nsEventStatus_eConsumeNoDefault, we don't want to do default
processing in browser UIs, so we should never return INPUT_RESULT_HANDLED.

Note that in the current code path, we never set mHandledByRootApzc in
ReceiveInputEvent() in the case of nsEventStatus_eConsumeNoDefault, as far as I
can tell.

Depends on D96331

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1674694 - Use ConvertAPZHandledResult to convert mHandledByRootApzc for motion event cases. r?botond

Depends on D96332

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1674694 - Use ConvertAPZHandledResult to convert mHandledByRootApzc for motion event cases. r?botond

Comment 5

[Hiroyuki Ikezoe (:hiro)]

I am running into a moz-phab issue (bug 1674310), so I had to create a new review request unfortunately. I am sorry, Botond.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e275c31e9f4
Change APZEventResult::mHandledByRootApzc to Maybe<APZHandledResult>. r=botond
https://hg.mozilla.org/integration/autoland/rev/a2f0dae16c37
Use ConvertAPZHandledResult nsEventStatus_eConsumeNoDefault case. r=botond,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/079ac6ad6133
Use ConvertAPZHandledResult to convert mHandledByRootApzc for motion event cases. r=botond,geckoview-reviewers,agi

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5e275c31e9f4
https://hg.mozilla.org/mozilla-central/rev/a2f0dae16c37
https://hg.mozilla.org/mozilla-central/rev/079ac6ad6133