Closed Bug 1674712 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26080 - Don't clear adoptedStyleSheets when moving shadow root between document <-> template

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26080 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26080
Details from upstream follow.

b'Rakina Zata Amni <rakina@chromium.org>' wrote:

Don't clear adoptedStyleSheets when moving shadow root between document <-> template

As discussed in https://github.com/WICG/construct-stylesheets/issues/133,
it should be safe to keep the adoptedStyleSheets when the shadow root
is moved between a document and a \<template> within that document. We
should still clear the adoptedStyleSheets when moving a shadow root
between documents outside of that case (e.g. between iframes).
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/W5-EGUySQgc/m/HxrySSpsBAAJ

Bug: 1111864
Change-Id: I803e75e6339f9228289188e4ed7d3f14c6e2432c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464519
Reviewed-by: Mason Freed \<masonfreed@chromium.org>
Commit-Queue: Rakina Zata Amni \<rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822999}

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/cssom/CSSStyleSheet-template-adoption.html
adoptedStyleSheets won'te be cleared when adopting into/from <template>s: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07197c657d2a
[wpt PR 26080] - Don't clear adoptedStyleSheets when moving shadow root between document <-> template, a=testonly

https://hg.mozilla.org/mozilla-central/rev/07197c657d2a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.