Closed Bug 1674713 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26354 - Fix justification when hyphenation points are at end of nodes

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26354 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26354
Details from upstream follow.

b'Koji Ishii <kojii@chromium.org>' wrote:

Fix justification when hyphenation points are at end of nodes

r819319 crrev.com/c/2476354 added |NGInlineItem.is_hyphenated|
as the flag to indicate whether it is hyphenated or not, but
failed to update |ApplyJustify|. This patch changes it to use
the flag instead of |hyphen_shape_result|.

Bug: 1141755
Change-Id: I49303b54c22c419a2dcf804cf40e4ec3b1a1f4ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511151
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823039}

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e00ec258d7b6
[wpt PR 26354] - Fix justification when hyphenation points are at end of nodes, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.