1674716 - Fix printing selection-only from the GTK print dialog.

Status: VERIFIED FIXED

(Core :: Printing: Setup, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame

I don't know when this broke, but we were not reading the gtk-specific
boolean even before https://hg.mozilla.org/mozilla-central/rev/c61a3b0cf79e350c400b48f6be97e08c1bfbe4aa

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I have no idea why or how, but this is the regression range mozregression came up with: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b6dc2f04666664338970daa11b766a181a701884&tochange=156ab3eba505488e7f30129525ec06f536beb8e9

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9185102 [details]
Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Printing selection from the old print ui or the system dialog doesn't work.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: select some text in some page on Linux, press Ctrl+P, click "Print with the system dialog" (if using the new print UI), click on the "Selection" checkbox, print to a file and make sure that only the selected text is printed.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple patch of obsolete code removal.
• String changes made/needed: none

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Jonathan made a convincing argument about this being regressed by bug 1668767.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0960216f538
Fix printing selection-only from the GTK print dialog. r=jfkthame

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1668767

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c0960216f538

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix on Ubuntu 20.04 x64 using latest 84.0a1 Nightly.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9185102 [details]
Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame

83 regression, verified bu QA, uplift approved for 83 beta 8, thanks.

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e306bbe6b56

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Also confirming that this issue no longer reproduces on Ubuntu 20 using Firefox 84.0 beta 4 and Firefox 83.0.