Closed Bug 1674716 Opened 1 year ago Closed 1 year ago

Fix printing selection-only from the GTK print dialog.

Categories

(Core :: Printing: Setup, defect)

defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- unaffected
firefox83 --- verified
firefox84 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
Regressed by: 1667081

Comment on attachment 9185102 [details]
Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame

Beta/Release Uplift Approval Request

  • User impact if declined: Printing selection from the old print ui or the system dialog doesn't work.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: select some text in some page on Linux, press Ctrl+P, click "Print with the system dialog" (if using the new print UI), click on the "Selection" checkbox, print to a file and make sure that only the selected text is printed.
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very simple patch of obsolete code removal.
  • String changes made/needed: none
Attachment #9185102 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Jonathan made a convincing argument about this being regressed by bug 1668767.

Regressed by: 1668767
No longer regressed by: 1667081
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0960216f538
Fix printing selection-only from the GTK print dialog. r=jfkthame

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect
QA Whiteboard: [qa-triaged]
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Confirming the fix on Ubuntu 20.04 x64 using latest 84.0a1 Nightly.

Comment on attachment 9185102 [details]
Bug 1674716 - Fix printing selection-only from the GTK print dialog. r=jfkthame

83 regression, verified bu QA, uplift approved for 83 beta 8, thanks.

Attachment #9185102 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Also confirming that this issue no longer reproduces on Ubuntu 20 using Firefox 84.0 beta 4 and Firefox 83.0.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.