Closed Bug 1674734 Opened 5 years ago Closed 5 years ago

Update AndroidX dependencies and replace deprecated API

Categories

(Data Platform and Tools :: Glean: SDK, task, P1)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janerik, Assigned: janerik)

Details

Attachments

(1 file)

A-C is upgrading AndroidX dependencies in https://github.com/mozilla-mobile/android-components/pull/8839

This triggers some deprecation warnings:

[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java

It's rather easy to resolve:

-    val activityRule: ActivityTestRule<MainActivity> = ActivityTestRule(MainActivity::class.java)
+    val activityRule: ActivityScenarioRule<MainActivity> = ActivityScenarioRule(MainActivity::class.java)

We should probably apply the same to the Glean SDK.

Priority: P3 → P2
Whiteboard: [telemetry:glean-rs:m?]
Assignee: nobody → jrediger
Priority: P2 → P1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: