1674779 - Improve documentation of GV_PAGE_LOAD_MS (describe back navigation and bimodality)

Status: RESOLVED FIXED

(Core :: Performance: General, enhancement)

Description

[Andrew Creskey [:acreskey]]

In Bug 1624360 we investigated the bimodality and suspiciously fast results of GV_PAGE_LOAD_MS probe in Fenix.

A primary cause was found to be the inclusion of back navigation. In particular, when this is performed via the BFCache the results are generally <50ms even on slower Android devices.

This bug is to improve the metrics.yaml and histogram.json documentation that teams making use of this probe can better understand the results.

Comment 1

[Andrew Creskey [:acreskey]]

Attachment: Bug 1674779 - Improve documentation of GV_PAGE_LOAD_MS (describe back navigation and bimodality) r=Dexter

Add notes to metrics.yaml and Histograms.json to describe a source of bimodality in this probe.

Comment 2

[Andrew Creskey [:acreskey]]

Hi Dexter, I put a patch with some improvements to the probe description. Can you please review or suggest someone else?

Comment 3

[Alessio Placitelli [:Dexter]]

Whoops, sorry for the delay. For some reason I did not receive the email notification for this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b130bd668e90
Improve documentation of GV_PAGE_LOAD_MS (describe back navigation and bimodality) r=Dexter

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset b130bd668e90 (Bug 1674779) for causing build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=fG_ZDHJQTCCNBgbXvdaN_A.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=b130bd668e90e2d964764e5df8948d770e0be8a4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=320989710&repo=autoland&lineNumber=57018

Backout: https://hg.mozilla.org/integration/autoland/rev/eb5717007985733f49cd8cce51298e3b32dc2136

Comment 6

[mac198442]

I am thinking replace the '<' with LT.

Comment 7

[Andrew Creskey [:acreskey]]

Sorry about that and thanks for the backout.
I left two trailing spaces in there.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3846467a384
Improve documentation of GV_PAGE_LOAD_MS (describe back navigation and bimodality) r=Dexter

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b3846467a384