1674780 - An NS_ERROR_FAILURE exception is always thrown while selecting "All address books" address book into the "Advanced Address Book Search" dialog.

Status: RESOLVED DUPLICATE of bug 1668147

(Thunderbird :: Address Book, defect)

Description

[Chris GAUDRY [:cmgaudry33]]

Attachment: thunderbird_78.4.0_abSearchDialog.xhtml.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36

Steps to reproduce:

In the "Advanced Address Book Search" dialog, select "All address books" to perform a search.

Actual results:

The following exception is thrown :

	NS_ERROR_FAILURE: The root address book no longer exists
		getDirectory resource:///modules/AddrBookManager.jsm:240
		GetScopeForDirectoryURI chrome://messenger/content/addressbook/abSearchDialog.js:148
		SelectDirectory chrome://messenger/content/addressbook/abSearchDialog.js:144
		oncommand chrome://messenger/content/addressbook/abSearchDialog.xhtml:1

Expected results:

Nothing because the user should not be able to select "All address books".

Comment 1

[Chris GAUDRY [:cmgaudry33]]

Pay attention to the patch file, it contains CRLFs instead of LF.

Comment 2

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Create New Attachment, [x] patch checkbox

Hi Chris, thank you so much for providing these patches, that's great (I've seen 5 within the last 3 days)!

May I ask you a favor?

Next time when creating a patch, could you do this:

• pls check the [x] patch checkbox, which will automatically add helpful action links here on BMO for reviewing your patch etc. (a small step for you, but a big step for the community... ;-))
• no need to set mime type text/x-patch, just accept the default setting (text/plain). Doesn't matter much, so if x-patch is better for you, that's ok.
• if possible (less important), use .diff as file extension.
• Ideally, your patch should also have a proper patch header (e.g. to show you as an author), like the one which I updated for you (attachment 9185553 [details] [diff] [review]). Normally, your tools should create that header for you. Let us know here or via private mail if you need help with that.

That would make it much easier to handle your patches. I do appreciate that you're volunteering, so no obligations. Tia :-))

Comment 3

[Thomas D. (:thomas8)]

Comment on attachment 9185169 [details] [diff] [review]
thunderbird_78.4.0_abSearchDialog.xhtml.patch

Review of attachment 9185169 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Unfortunately, this would prevent searching "All Address Books" in advanced AB search, which is undesired.
That said, we have already fixed this in Bug 1668147, which is about to land on release channel in 78.4.1 per Bug 1668147 Comment 14.

::: comm/mail/components/addrbook/content/abSearchDialog.xhtml
@@ -63,5 @@
>          <hbox align="center">
>            <label value="&abSearchHeading.label;" accesskey="&abSearchHeading.accesskey;" control="abPopup"/>
>            <menulist is="menulist-addrbooks" id="abPopup"
>                      oncommand="SelectDirectory(this.value);"
> -                    alladdressbooks="true"

This would eliminate the error, but we *do* want all address books to be searchable...

Comment 4

[Thomas D. (:thomas8)]

Fixed for 78.4.1 per Bug 1668147 Comment 14, so this is a duplicate.

Comment 5

[Chris GAUDRY [:cmgaudry33]]

Hi Thomas,

I am not working with git because I am working offline on the code resulting from installing the app.
Anyway, next time it will be quite possible for me to:

• submit my new bug;
• noted the identifier of the request;
• format and name my patch file as expected (except the comment "# Parent ...");
• submit my patch as expected.

Thank you for all this information which will allow me to help you as well as possible.

Otherwise I have 4 pending requests, with a patch file for each, can I modify my requests to format and rename these files?

Comment 6

[Thomas D. (:thomas8)]

(In reply to Chris GAUDRY from comment #5)

[snip]

• submit my patch as expected.

Awesome. :-)

Thank you for all this information which will allow me to help you as well as possible.

Most welcome! Thank you for helping the project!

Otherwise I have 4 pending requests, with a patch file for each, can I modify my requests to format and rename these files?

You can change file name, mime type, [x] patch, and the attachment description by clicking on the Details link on the far right of your attachment at the top of the bug report, and then again on (edit Details) link next to the second header which has the file name of the attachment (near top-center). You cannot change the content of an existing attachment. But you can always add a new attachment and mark the old one obsolete when filing the new one.

I'll set the [x] patch checkmark on your patches when I look at them because otherwise it's too difficult to view them on this platform.