1674781 - An NS_ERROR_UNEXPECTED exception is always thrown while searching in any address book into the "Advanced Address Book Search" dialog

Status: RESOLVED DUPLICATE of bug 1668147

(Thunderbird :: Address Book, defect)

Description

[Chris GAUDRY [:cmgaudry33]]

Attachment: thunderbird_78.4.0_abSearchDialog.js.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36

Steps to reproduce:

• Display the "Advanced Address Book Search" dialog.
• Select any address book.
• Enter a search criteria
• Perform the search

Actual results:

The following exception is always thrown without any result :

	NS_ERROR_UNEXPECTED: Unexpected uri: jsaddrbook://abook-<ADDRESS_BOOK_NUMBER>.sqlite?(and(DisplayName,c,<SEARCH_CRITERIA>))
		init resource:///modules/AddrBookDirectory.jsm:145
		createDirectoryObject resource:///modules/AddrBookManager.jsm:120
		getDirectory resource:///modules/AddrBookManager.jsm:280
		GetDirectoryFromURI chrome://messenger/content/addressbook/abCommon.js:998
		SetAbView chrome://messenger/content/addressbook/abResultsPane.js:84
		onSearch chrome://messenger/content/addressbook/abSearchDialog.js:337
		onSearchButton chrome://messenger/content/addressbook/abSearchDialog.js:343
		oncommand chrome://messenger/content/addressbook/abSearchDialog.xhtml:1

Expected results:

No exception

Comment 1

[Chris GAUDRY [:cmgaudry33]]

Pay attention to the patch file, it contains CRLFs instead of LF.

Comment 2

[Magnus Melin [:mkmelin]]

Bug 1668147 likely fixed it. Can you test 78.4.1 when that's out (soon).

Comment 3

[Chris GAUDRY [:cmgaudry33]]

I confirm that it is fixed in 78.4.1.

Comment 4

[Thomas D. (:thomas8)]

Comment on attachment 9185171 [details] [diff] [review]
thunderbird_78.4.0_abSearchDialog.js.patch

Review of attachment 9185171 [details] [diff] [review]:
-----------------------------------------------------------------

Chris, thank you for providing this patch, which was fixing the right spot in the right way code-wise. Nice work!
You'll find that the patch on Bug 1668147 (https://phabricator.services.mozilla.com/D91884) also includes your fix in a slight variation.
Which unfortunately makes your bug a duplicate of that.

::: comm/mail/components/addrbook/content/abSearchDialog.js
@@ +186,5 @@
>  
>    gSearchSession.addDirectoryScopeTerm(GetScopeForDirectoryURI(currentAbURI));
>    saveSearchTerms(gSearchSession.searchTerms, gSearchSession);
>  
> +  var searchQuery = "?(";

We use let for any variables inside functions. Nice renaming of the variable.

Comment 5

[Thomas D. (:thomas8)]

ni?Chris (FYI)

To avoid creating patches for bugs which others have already fixed (or are in the process of fixing):

• Check if a bug for your problem already exists:
  • When you enter your summary, BMO will list existing bugs (including fixed), check them carefully
  • Search for existing bugs (including fixed, using ALL keyword) yourself, in this case e.g. you could have searched for:
    https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20%3Athun%2Cmailn%20Advanced%20Address%20Book%20Search&list_id=15484326
• Ensure that you're using the "Thunderbird Daily" release channel for fixing bugs. You can still use your preferred method. Note that your patches must apply to "Trunk" (almost same as Daily) anyway.
  • Download Daily from here: https://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-central/
  • Install separately with a separate test profile (should do that automatically) - don't use important production data with Daily.
  • Adjust your Daily start link like this:
    "...\thunderbird.exe" -no-remote -purgecaches -devtools -allow-downgrade
  • Switch off automatic upgrading so that it doesn't get in the way, and decline upgrade requests until you're ready for them.
    ≡ > Options > search for "Updates" > (o) Check for Updates, but let me choose whether to install them.

Comment 6

[Thomas D. (:thomas8)]

Resolved duplicate per reporter's comment 3 and per patch content.

Comment 7

[Chris GAUDRY [:cmgaudry33]]

Sorry for the inconvenience but I get paid to work on the latest French release.
I will try to format my patch for the daily US version. But I can't really test it which it doesn't really suit me.