1674801 - Other Bookmarks popup doesn't update when bookmark is deleted from it

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Micah [:mtigley] (she/her)]

STR:

1. Have latest Nightly opened.
2. Have some bookmarks stored in Other Bookmarks folder.
3. Click the Other Bookmarks button in the toolbar and right click one of the menu popup items.
4. Select "Delete"

AR:
The menu popup doesn't update. The bookmark item should have been removed as soon as "Delete" was selected. The user needs to reopen the popup to see the updated menu items.

ER:
The menu popup still displays the deleted bookmark.

Comment 1

[Micah [:mtigley] (she/her)]

This issue should be fixed by the work in Bug 1674756.

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1674801 - Add a test ensuring that Other Bookmarks menu popup updates when items are deleted from it. r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2697818f40d
Add a test ensuring that Other Bookmarks menu popup updates when items are deleted from it. r=jaws

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1674801, bug 1674756) for Browse-chrome failures in places/tests/browser/browser_toolbar_other_bookmarks.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=320758639&repo=autoland&lineNumber=16014

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d2697818f40d1dc457bbc2eb662dba0b7729632a

Backout:
https://hg.mozilla.org/integration/autoland/rev/ea0a80f21a21fadfe8a924116fa530555c321e04

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9bd2f1f70f
Add a test ensuring that Other Bookmarks menu popup updates when items are deleted from it. r=jaws

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0b9bd2f1f70f

Comment 7

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified this issue on Fx 84.0b2 on Win 10, ubuntu 18.04 and mac os 10.15.