1674839 - Trimmable line-initial space is not ignored when computing min-width

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: white-space-3.html

See attached testcase (based on an element of the existing white-space-2 reftest). Note that the table cell should shrink-wrap its contents.

There are two spaces between the words "Hi" and "Kitty". The first has white-space:pre-wrap, and the second has white-space:nowrap. We break the line after the first space (we can't break after the second one because of nowrap), so the second space is at the beginning of the second line.

Being line-initial whitespace (and not white-space:pre) it is trimmed for rendering, so the word "Kitty" appears left-aligned. However, we fail to ignore the width of the space when computing the minimum inline-size of the line, and therefore the table cell ends up wider than necessary, with spurious blank space after "Kitty".

FWIW, Chrome gets this right. (Safari gets it wrong, although in a different way than we do.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1674839 - Skip trimmable whitespace after a line-break when computing min inline-width for a textframe. r=#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1e9eae14a74
Skip trimmable whitespace after a line-break when computing min inline-width for a textframe. r=emilio

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b1e9eae14a74