Closed Bug 1674945 Opened 4 years ago Closed 4 years ago

Intermittent browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Uncaught exception - Toolbar should not become visible when loading slow site - TypeError: can't access property "querySelector", win.gNavToolbox undefined

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- unaffected
firefox83 --- unaffected
firefox84 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1674945 - fix conditions in browser_aboutNewTab_bookmarksToolbarNewWindow.js to not throw exceptions when gNavToolbox is null, r?jaws
47 bytes, text/x-phabricator-request
Details | Review

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=320533829&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ox0wEntZTeqVJb68tqZOxA/runs/0/artifacts/public/logs/live_backing.log

[task 2020-11-03T00:25:26.905Z] 00:25:26     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Toolbar hidden on slow site - 
[task 2020-11-03T00:25:26.905Z] 00:25:26     INFO - Testing with the feature disabled and newtab enabled
[task 2020-11-03T00:25:26.905Z] 00:25:26     INFO - Buffered messages finished
[task 2020-11-03T00:25:26.906Z] 00:25:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | Uncaught exception - Toolbar should not become visible when loading slow site - threw exception: TypeError: can't access property "querySelector", win.gNavToolbox is undefined
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - Leaving test bound bookmarks_toolbar_shown_on_newtab
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - GECKO(1912) | [Child 3665: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7fea4f5cd040) [pid = 3665] [serial = 1] [outer = (nil)] [url = https://example.com/browser/browser/base/content/test/about/slow_loading_page.sjs]
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - GECKO(1912) | [Child 3665: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x7fea4f548c00) [pid = 3665] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - GECKO(1912) | [Child 3665: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x7fea4f866c00) [pid = 3665] [serial = 3] [outer = (nil)] [url = https://example.com/browser/browser/base/content/test/about/slow_loading_page.sjs]
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - GECKO(1912) | [Child 3665, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3359
[task 2020-11-03T00:25:26.907Z] 00:25:26     INFO - GECKO(1912) | [Child 3665, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4287
[task 2020-11-03T00:25:27.055Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7f2b9460c400) [pid = 2057] [serial = 44] [outer = (nil)] [url = about:blank]
[task 2020-11-03T00:25:27.055Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7f2b946e6800) [pid = 2057] [serial = 36] [outer = (nil)] [url = about:newtab]
[task 2020-11-03T00:25:27.091Z] 00:25:27     INFO - GECKO(1912) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f0ee19c7c00 == 11 [pid = 1912] [id = 14]
[task 2020-11-03T00:25:27.091Z] 00:25:27     INFO - GECKO(1912) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 25 (0x7f0ef65ac580) [pid = 1912] [serial = 30] [outer = (nil)]
[task 2020-11-03T00:25:27.092Z] 00:25:27     INFO - GECKO(1912) | [Parent 1912, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:347
[task 2020-11-03T00:25:27.175Z] 00:25:27     INFO - GECKO(1912) | [Child 3692: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7ff5cb7f1000 == 1 [pid = 3692] [id = 0]
[task 2020-11-03T00:25:27.216Z] 00:25:27     INFO - GECKO(1912) | [Child 3692: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7ff5c54cc040) [pid = 3692] [serial = 1] [outer = (nil)]
[task 2020-11-03T00:25:27.219Z] 00:25:27     INFO - GECKO(1912) | [Child 3692: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7ff5c5446c00) [pid = 3692] [serial = 2] [outer = 0x7ff5c54cc040]
[task 2020-11-03T00:25:27.428Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7f2b97f0b200) [pid = 2057] [serial = 40] [outer = (nil)] [url = about:newtab]
[task 2020-11-03T00:25:27.429Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f2b9351c800 == 3 [pid = 2057] [id = 13] [url = about:newtab]
[task 2020-11-03T00:25:27.429Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7f2b97f0b580) [pid = 2057] [serial = 37] [outer = (nil)] [url = about:newtab]
[task 2020-11-03T00:25:27.430Z] 00:25:27     INFO - GECKO(1912) | [Child 2057: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f2b93520000 == 2 [pid = 2057] [id = 12] [url = about:newtab]
[task 2020-11-03T00:25:27.437Z] 00:25:27     INFO - GECKO(1912) | MEMORY STAT | vsize 3326MB | residentFast 394MB | heapAllocated 137MB
[task 2020-11-03T00:25:27.438Z] 00:25:27     INFO - TEST-OK | browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js | took 4448ms```
Flags: needinfo?(jaws)
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1673363

status-firefox82: --- → unaffected
status-firefox83: --- → unaffected
status-firefox84: --- → affected
status-firefox-esr78: --- → unaffected
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d0ab7a27cc41
fix conditions in browser_aboutNewTab_bookmarksToolbarNewWindow.js to not throw exceptions when gNavToolbox is null, r=jaws

https://hg.mozilla.org/mozilla-central/rev/d0ab7a27cc41

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: