[Wayland] Revert Bug 1668771 (frame callbacks timeout) due to OOM crashes
Categories
(Core :: Widget: Gtk, defect, P3)
Tracking
()
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
We need to revert Bug 1668771 (frame callbacks timeout) due to OOM crashes.
Wayland protocol does not include a mechanism how to inform compositor about deleted frame callbacks. We delete the callback only locally on client side and it remains active at server (compositor) side.
When large amount of callbacks is accumulated at server Firefox is closed due to OOM.
Assignee | ||
Comment 1•4 years ago
|
||
Wayland protocol does not include a mechanism how to inform compositor about deleted frame callbacks.
We delete a callback only locally on client side and it remains active at server (compositor) side.
When large amount of callbacks is accumulated at server Firefox is closed due to OOM
so we need to keep frame callback on local side untill is fired and don't create a new one.
Assignee | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
bugherder |
Comment 4•4 years ago
|
||
Martin, it seems we want this patch uplifted to 83 beta, right?
Assignee | ||
Comment 5•4 years ago
|
||
Yes, I'd like to uplift this one.
Thanks.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9185413 [details]
Bug 1674982 [Wayland] Revert frame callbacks timeout due to OOM crashes, r?jhorak
Beta/Release Uplift Approval Request
- User impact if declined: Firefox crashes when it's rendering web content on background, like youtube playback on background or so.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Low risk - it only reverts a single patch which causes the failure.
- String changes made/needed: none
Comment 7•4 years ago
|
||
Comment on attachment 9185413 [details]
Bug 1674982 [Wayland] Revert frame callbacks timeout due to OOM crashes, r?jhorak
Linux recent crash fix on Wayland, approved for beta 9, thanks.
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•4 years ago
|
Description
•