1675000 - Dialogs and windows in Thunderbird use flat UI even in high-contrast mode

Status: RESOLVED FIXED

(Thunderbird :: Disability Access, defect)

Description

[Kostadin Kolev]

Attachment: Thunderbird flat UI controls in dialogs in high-contrast mode

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4299.0 Safari/537.36 Edg/88.0.688.0

Steps to reproduce:

1. Enable high-contrast mode in Windows 10, by doing the following:
   1.1. Open Windows Settings (Windows+I).
   1.2. Go to Ease of access -> High-contrast.
   1.3. Turn on the high-contrast mode, using the respective toggle.
   1.4. From the "High-contrast theme" combo-box, select "High-Contrast Black".
2. Launch Thunderbird.
3. Invoke some dialogs/windows (e.g. IMAP folder properties, Message Filtering, Add Existing Account, etc.).
4. Take a look at the 4th screenshot in the attached archive, named "004_IE_Tabs-Options.png".
5. Compair how the controls in the Thunderbird dialogs/windows look in high-contrast black mode in comparison with the ones in the "Tabbed browsing settings" dialog for IE, taken from Control Panel ➡ internet Options ➡ "General" tab ➡ "Tabs" button.

Actual results:

The controls in Thunderbird's dialogs/windows use a flat UI even in high-contrast mode, but they should not as Windows does not. Not using a flat UI provides better contrast, by adding contours to the controls.

Expected results:

Thunderbird's dialogs/windows should not use a flat UI in high-contrast mode, so they can provide better contrast.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1675000-HC-button-colors-themeable-dialogs.patch

Sorry John to ask you again, this should be the last patch for some time.

To test, please change to Win 10 high contrast mode and open a dialog like the Search messages (CTRL + SHIFT +F) or the Add existing Mail Account. The buttons, menulists and textboxes should all use the correct colours. Be sure not to have set a TB theme, then the theme settings are still used.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1675000-HC-button-colors-themeable-dialogs.patch

Better fix that works now correct on Contrast Black and Contrast White. Before the button text wasn't correct which I didn't saw on Contrast No 1.

Comment 3

[Richard Marti (:Paenglab)]

Thanks, John.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6941fbbd6ede
Use systen colors for buttons/menulists in themeable dialogs. r=TbSync