Closed Bug 1675115 Opened 4 years ago Closed 4 years ago

Remote settings client fails to apply the sort order to loaded dumps

Categories

(Firefox :: Remote Settings Client, defect)

Product:
Firefox
Component:
Remote Settings Client
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: standard8, Assigned: leplatrem)

Details

Attachments

(1 file)

Bug 1675115 - Fix sorting of records on .get() r?standard8
47 bytes, text/x-phabricator-request
Details | Review

Database.list() expects an options object as an argument, and the options object to have a property called sort:

https://searchfox.org/mozilla-central/rev/e75e8e5b980ef18f4596a783fbc8a36621de7d1e/services/settings/Database.jsm#33

However, RemoteSettingsClient.get() is passing a property called order:

https://searchfox.org/mozilla-central/rev/e75e8e5b980ef18f4596a783fbc8a36621de7d1e/services/settings/RemoteSettingsClient.jsm#390

This causes the sort to never get applied to dumps unless we're in the fallback situation which uses a direct call.

Assignee: nobody → mathieu
Status: NEW → ASSIGNED
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84de785727f6
Fix sorting of records on .get() r=Standard8

https://hg.mozilla.org/mozilla-central/rev/84de785727f6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: