Closed Bug 1675117 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26378 - Do not apply text-underline-offset to overline decoration

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26378 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26378
Details from upstream follow.

b'Dominik R\xc3\xb6ttsches <drott@chromium.org>' wrote:

Do not apply text-underline-offset to overline decoration

Take into account swapping of underline and overline in vertical, when
using text-underline-position "right" and "left".

Add 3 WPT tests to ensure text-overline-offset is not applied to
overline and that the underline on the correct side is offset in
vertical.

Bug: 1143600
Change-Id: Idd52a5d2d953fc486050ef20a1960ab51145521c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510829
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Stephen Chenney \<schenney@chromium.org>
Commit-Queue: Dominik Röttsches \<drott@chromium.org>
Auto-Submit: Dominik Röttsches \<drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823706}

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

PASS: 1
FAIL: 2

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77a3617dd808
[wpt PR 26378] - Do not apply text-underline-offset to overline decoration, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.