Closed Bug 1675128 Opened 7 months ago Closed 7 months ago

Convert ReflowInput'::mComputedOffsets to logical coordinates

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 5 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

The approach of this bug should be similar to bug 1674450 comment 0.

Also, convert its implementation to use more logical APIs.

Depends on D96126

While I'm at this, I also convert the computation in RecomputePosition()
into logical coordinates.

Depends on D96127

Remove it to encourage people to use existing API to get logical side.

Depends on D96129

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1b44b1d83458
Part 1 - Add WritingMode argument to ReflowInput::SetComputedLogicalOffsets(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/78261df44adc
Part 2 - Add WritingMode argument to ReflowInput::ComputedLogicalOffsets(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/276db1fd9cf2
Part 3 - Make ReflowInput::ComputeRelativeOffsets() return the offset in LogicalMargin. r=emilio
https://hg.mozilla.org/integration/autoland/rev/576b43399318
Part 4 - Remove ReflowInput::ComputedPhysicalOffsets() that returns a writable-reference. r=emilio
https://hg.mozilla.org/integration/autoland/rev/09693271e582
Part 5 - Store ReflowInput::mComputedOffsets in LogicalMargin. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0b430b271213
Part 6 - Remove nsStylePosition::OffsetHasPercent(). r=emilio
You need to log in before you can comment on or make changes to this bug.