Closed Bug 1675160 Opened 4 years ago Closed 4 years ago

macOS artifact try-c-c builds do not include librnp.dylib (OSX --artifact builds for OpenPGP will fail)

Categories

(Thunderbird :: Build Config, task)

Product:
Thunderbird
Component:
Build Config
Type:
task

Tracking

(thunderbird_esr78 wontfix, thunderbird85 wontfix)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird85 --- wontfix

People

(Reporter: rjl, Assigned: justdave)

Details

Attachments

(1 file)

Bug 1675160 - Extract all *.dylib from Mac artifacts for Linux/Win parity, r?rjl,#firefox-build-system-reviewers
47 bytes, text/x-phabricator-request
Details | Review

librnp.dylib should be in the MacOS folder of the application DMG, but it is not. This only seems to be happening on try-c-c builds using --artifact. Other platforms have it.

This is hindering mochitest development on the OpenPGP dialogs.

Assignee: nobody → justdave

Problem is the file isn't being extracted from the downloaded dmg artifact. The manifest for what to extract is in python/mozbuild/mozbuild/artifacts.py

Patch coming shortly.

If you're testing this locally, you'll need to run mach artifact clear-cache before building to pick up the change.

Status: NEW → ASSIGNED
Summary: macOS artifact try-c-c builds do not include librnp.dylib → macOS artifact try-c-c builds do not include librnp.dylib (OSX --artifact builds for OpenPGP will fail)
Attachment #9185922 - Attachment description: Bug 1675160 - Extract librnp.dylib from Mac Thunderbird artifacts, r?rjl → Bug 1675160 - Extract all *.dylib from Mac artifacts for Linux/Win parity, r?rjl,#firefox-build-system-reviewers

The Windows one extracts *.dll and Linux extracts *.so, so there's no reason the Mac one shouldn't just extract *.dylib instead of having a list of them.
Updated patch reflects that.

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/integration/autoland/rev/6513d67e0618
Extract all *.dylib from Mac artifacts for Linux/Win parity, r=rjl,firefox-build-system-reviewers,nalexander

https://hg.mozilla.org/mozilla-central/rev/6513d67e0618

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: