1675306 - Permafailing tier 2 python/mozbuild/mozbuild/test/configure/test_checks_configure.py::TestChecksConfigure::test_java_tool_checks TEST-UNEXPECTED-FAIL

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=320727640&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/f8VSHNDuTW-VEgLA65Fsaw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-11-04T16:01:43.080Z]  0:14.74 python/mozbuild/mozbuild/test/configure/test_checks_configure.py::TestChecksConfigure::test_id_and_secret_keyfile PASSED
[task 2020-11-04T16:01:43.081Z]  0:14.74 python/mozbuild/mozbuild/test/configure/test_checks_configure.py::TestChecksConfigure::test_java_tool_checks TEST-UNEXPECTED-FAIL
[task 2020-11-04T16:01:43.081Z]  0:14.74 python/mozbuild/mozbuild/test/configure/test_checks_configure.py::TestChecksConfigure::test_pkg_check_modules PASSED
[task 2020-11-04T16:01:43.081Z]  0:14.74 python/mozbuild/mozbuild/test/configure/test_checks_configure.py::TestChecksConfigure::test_simple_keyfile PASSED
[task 2020-11-04T16:01:43.082Z]  0:14.74 
[task 2020-11-04T16:01:43.082Z]  0:14.74 =================================== FAILURES ===================================
[task 2020-11-04T16:01:43.082Z]  0:14.74 __________________ TestChecksConfigure.test_java_tool_checks ___________________
[task 2020-11-04T16:01:43.083Z]  0:14.74 
[task 2020-11-04T16:01:43.083Z]  0:14.74 self = <test_checks_configure.TestChecksConfigure testMethod=test_java_tool_checks>
[task 2020-11-04T16:01:43.083Z]  0:14.74 
[task 2020-11-04T16:01:43.083Z]  0:14.74     def test_java_tool_checks(self):
[task 2020-11-04T16:01:43.084Z]  0:14.74         # A valid set of tools in a standard location.
[task 2020-11-04T16:01:43.084Z]  0:14.74         java = mozpath.abspath("/usr/bin/java")
[task 2020-11-04T16:01:43.084Z]  0:14.74 
[task 2020-11-04T16:01:43.084Z]  0:14.74         paths = {java: None}
[task 2020-11-04T16:01:43.085Z]  0:14.74 
[task 2020-11-04T16:01:43.087Z]  0:14.74         script = textwrap.dedent(
[task 2020-11-04T16:01:43.087Z]  0:14.74             """\
[task 2020-11-04T16:01:43.087Z]  0:14.74                     @depends('--help')
[task 2020-11-04T16:01:43.087Z]  0:14.74                     def host(_):
[task 2020-11-04T16:01:43.087Z]  0:14.74                         return namespace(os='unknown')
[task 2020-11-04T16:01:43.088Z]  0:14.74                     include('%(topsrcdir)s/build/moz.configure/java.configure')
[task 2020-11-04T16:01:43.088Z]  0:14.74                 """
[task 2020-11-04T16:01:43.088Z]  0:14.74             % {"topsrcdir": topsrcdir}
[task 2020-11-04T16:01:43.088Z]  0:14.74         )
[task 2020-11-04T16:01:43.088Z]  0:14.74 
[task 2020-11-04T16:01:43.089Z]  0:14.74         config, out, status = self.get_result(command=script, extra_paths=paths)
[task 2020-11-04T16:01:43.089Z]  0:14.74 >       self.assertEqual(status, 0)
[task 2020-11-04T16:01:43.089Z]  0:14.74 E       AssertionError: 1 != 0
[task 2020-11-04T16:01:43.090Z]  0:14.74 
[task 2020-11-04T16:01:43.090Z]  0:14.74 python/mozbuild/mozbuild/test/configure/test_checks_configure.py:578: AssertionError
[task 2020-11-04T16:01:43.090Z]  0:14.74 ------------------------------ Captured log call -------------------------------
[task 2020-11-04T16:01:43.090Z]  0:14.74 __init__.py                432 ERROR    Could not find "java" on the $PATH. Please install the Java 1.8 JDK.
[task 2020-11-04T16:01:43.090Z]  0:14.74 =========================== short test summary info ============================```

Comment 1

[Natalia Csoregi [:nataliaCs]]

:mhentges any chance you could take a quick look at this?
Thank you

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

For sure, thanks for the report :)

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Hmm, it looks like the test didn't use to fail because our test case would tell the configure sandbox "hey, /usr/local/bin/java exists". Then, when the real java-detection code would run, it would use configure's special which() function, which respects the "mock file" configuration.

However, the new Java-detection code is outside of configure (since it's shared with bootstrap). This means that it can't use that custom which() function that respects the inject mock files.

Comment 4

[Intermittent Failures Robot]

37 failures in 747 pushes (0.05 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 31
• mozilla-central: 6

Platform breakdown:

• linux1804-64: 13
• windows10-64: 14
• macosx1014-64: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1675306&startday=2020-11-04&endday=2020-11-04&tree=all

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1670264

Comment 6

[Intermittent Failures Robot]

60 failures in 865 pushes (0.069 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 12
• autoland: 48

Platform breakdown:

• macosx1014-64: 20
• linux1804-64: 20
• windows10-64: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1675306&startday=2020-11-05&endday=2020-11-05&tree=all

Comment 7

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1675306: Add mocks so Java-detection doesn't hit real file system

Previously, configure checked for Java binaries using
"configure"-specific "which()" and environment-variable-getter
functions. When bug 1670264 changed Java detection to use logic shared
between "configure" and "bootstrap", more general "which()"
/environment-variable-getter functions were used.

The test used to work because the "configure"-specific functions
respect the mocked-out file system and environment variables.
This patch adjusts the test to add mocks so the more general logic
is redirected to respect the mocked data.

Comment 8

[Natalia Csoregi [:nataliaCs]]

The patch seems to be reviewed.
Mitchell, if there are no other restrictions, could we have this landed? Could you please add the check-in needed tag and the testing tag if so?
Thank you.

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

I'm just doing one more try run with reviewer-recommended improvements, then I'll land this 👍

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d009f39bc727
Add mocks so Java-detection doesn't hit real file system r=firefox-build-system-reviewers,rstewart

Comment 11

[Intermittent Failures Robot]

96 failures in 737 pushes (0.13 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 78
• mozilla-central: 18

Platform breakdown:

• windows10-64: 32
• macosx1014-64: 33
• linux1804-64: 31

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1675306&startday=2020-11-06&endday=2020-11-06&tree=all

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d009f39bc727

Comment 13

[Intermittent Failures Robot]

193 failures in 4128 pushes (0.047 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 157
• mozilla-central: 36

Platform breakdown:

• linux1804-64: 64
• windows10-64: 66
• macosx1014-64: 63

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1675306&startday=2020-11-02&endday=2020-11-08&tree=all