1675320 - "WebDriver:NewWindow" causes race conditions because it doesn't wait until the initial "about:blank" has been finished loading

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discovered on bug 1673851 comment 11 the WebDriver:NewWindow command currently doesn't await the load of about:blank, and as such creates race conditions with the next command(s) due to an unexpected page load happening.

Because the WebDriver spec doesn't mention it yet, I filed https://github.com/w3c/webdriver/issues/1560.

Nevertheless we have to get it implemented in Marionette, and I don't think we have to wait for the spec to be updated.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving to Julian because he already has patch in the works.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7).

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1675320 - [marionette] Add register/unregisterEventsActor helpers to MarionetteEventsParent

Expose the boilerplate code to register the MarionetteEventsActor to later reuse it from driver.js

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1675320 - [marionette] Listen to load event for MarionetteEvent actor

Depends on D96117

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1675320 - [marionette] Wait for the pageshow event in newWindow command

Depends on D96118

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note that my patch on bug 1675248 caused perma failures for the wdspec new window tests. Maybe it's a good way to verify that this change works as expected.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1675320 - [marionette] Add waitForLoadEvent helper to sync.js

Depends on D96119

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb6072f5d067
[marionette] Add register/unregisterEventsActor helpers to MarionetteEventsParent r=marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/0206b72af90a
[marionette] Wait for the pageshow event in newWindow command r=marionette-reviewers,whimboo

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bb6072f5d067
https://hg.mozilla.org/mozilla-central/rev/0206b72af90a