nsCertOverrideService should only block shutdown when a write is pending
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Bug 1634065 involves changing how some PSM services get initialized. It turns out that doing this causes services/crypto/tests/unit/test_crypto_random.js to fail various assertions in the JS engine. I don't fully understand the issue, but I tracked it down to marking nsCertOverrideService as a shutdown blocker unconditionally. I was able to work around the issue by only marking the service as a blocker when there's a write event happening, which is arguably more correct anyway.
|
Assignee | |
Comment 1•4 years ago
|
||
Bug 1634065 will involve changing when nsCertOverrideService gets initialized.
It turns out that doing this causes
services/crypto/tests/unit/test_crypto_random.js to fail various assertions in
the JS engine. It's unclear what the underlying issue is, but the failures
happen as a result of marking nsCertOverrideService as a shutdown blocker
unconditionally in its initialization. This patch works around this by marking
the service as a blocker only when there's a write event happening, which is
arguably more correct anyway.
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a38599a04b9 make nsCertOverrideService only block shutdown when a write is pending r=kjacobs
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•