1675395 - swgl's build script does not pass -Xclang to clang-cl on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Barret Rennie [:barret] (they/them)]

The build script for swgl does not pass -Xclang to clang-cl.exe on Windows, leading to options being ignored:

 0:48.53 warning: clang-cl: warning: unknown argument ignored in clang-cl: '-std=c++14' [-Wunknown-argument]
 0:48.53 warning: clang-cl: warning: unknown argument ignored in clang-cl: '-fno-exceptions' [-Wunknown-argument]
 0:48.53 warning: clang-cl: warning: unknown argument ignored in clang-cl: '-fno-rtti' [-Wunknown-argument]
 0:48.53 warning: clang-cl: warning: unknown argument ignored in clang-cl: '-fno-math-errno' [-Wunknown-argument]

clang-cl.exe accepts cl.exe style arguments (/std:c++14) unless you pass -Xclang to use clang frontend arguments.

Comment 1

[Masatoshi Kimura [:emk]]

This is still an issue (although -std=c++14 has been changed to -std=c++17):

3:22.34 warning: clang: warning: unknown argument ignored in clang-cl: '-std=c++17' [-Wunknown-argument]
3:22.34 warning: clang: warning: unknown argument ignored in clang-cl: '-fno-exceptions' [-Wunknown-argument]
3:22.34 warning: clang: warning: unknown argument ignored in clang-cl: '-fno-rtti' [-Wunknown-argument]
3:22.34 warning: clang: warning: unknown argument ignored in clang-cl: '-fno-math-errno' [-Wunknown-argument]

Comment 2

[Masatoshi Kimura [:emk]]

clang options	corresponding msvc options
-std=c++17	/std:c++17
-fno-exceptions	/EHs-
-fno-rtti	/GR-
-fno-math-errno	none, but clang defaults to -fno-math-errno

Or we can just prepend -Xclang or /clang: to every options.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1675395 - Pass in flags for MSVC-like compilers in SWGL build script. r?jrmuizel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01686a5407ac
Pass in flags for MSVC-like compilers in SWGL build script. r=jrmuizel

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/01686a5407ac