1675397 - Cleanup some code around nsFocusManager::mFirst{Blur|Focus}Event

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P2)

Description

[Edgar Chen [:edgar]]

• nsFocusManager::mFirst{Blur|Focus}Event could be RefPtr<Element>, https://searchfox.org/mozilla-central/rev/c938c7416c633639a5c8ce4412be586eefb48005/dom/base/nsFocusManager.h#873-874.

• Use AutoRestore in

  • https://searchfox.org/mozilla-central/rev/c938c7416c633639a5c8ce4412be586eefb48005/dom/base/nsFocusManager.cpp#2157-2161,2331
  • https://searchfox.org/mozilla-central/rev/c938c7416c633639a5c8ce4412be586eefb48005/dom/base/nsFocusManager.cpp#2397-2401,2577-2579

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1675397 - Part 1: Use RefPtr<Element> for nsFocusManager::mFirst{Blur|Focus}Event;

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1675397 - Part 2: Use AutoRestore to reset nsFocusManager::mFirst{Blur|Focus}Event;

Depends on D95946

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ba1d1e9d326
Part 1: Use RefPtr<Element> for nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/6f32f9a87905
Part 2: Use AutoRestore to reset nsFocusManager::mFirst{Blur|Focus}Event; r=hsivonen

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4ba1d1e9d326
https://hg.mozilla.org/mozilla-central/rev/6f32f9a87905