Closed Bug 1675478 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 26411 - Ensure we set a testdriver context when running in a non-test window

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26411 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26411
Details from upstream follow.

b'James Graham <james@hoppipolla.co.uk>' wrote:

Ensure we set a testdriver context when running in a non-test window

 testdriver can be used outside the test window in two ways:
 
 * By passing in a context parameter pointing to another window in
 which the commands should be run.
 
 * By loading testdriver in the other window and having it postMessage
 commands back to the top window.
 
 For the first case the context parameter being null means "run the
 command in the test window". However we were also passing null in the
 second case when the command should be run in the window where
 testdriver was loaded. That meant the command was actually run in the
 test window rather than the target. It just so happened this didn't
 cause test failures in Chrome and Firefox because of the specific
 choice of commands in the tests. But it did in Firefox with site
 isolation enabled and Safari and would for a different set of tests.
 
 The fix is to ensure that the context is always set when postMessaging
 a command to the top-level window.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73544b4b1c52 [wpt PR 26411] - Ensure we set a testdriver context when running in a non-test window , a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.